status-im
/
react-native
mirror of https://github.com/status-im/react-native.git
2
0
Fork 0
Code Issues Projects Releases Wiki Activity
react-native/Libraries
History
Janic Duplessis 10b642a7af Verify that the component passed to createAnimatedComponent is not functional 
Summary:
Stateless functional components don't support refs and we need that for the component to work, it used to crash with this error message: `undefined is not an object (evaluating 'this._component.getScrollableNode')`. This makes it clear what the issue is.

Fixes some of the errors in #10635, not sure if it fixes all the cases described in the issue though.

**Test plan**
Tested that passing a component with createClass or extends Component works but passing a function causes an error.

[GENERAL] [ENHANCEMENT] [Animated] - Verify that the component passed to createAnimatedComponent is not functional
Closes https://github.com/facebook/react-native/pull/15019

Differential Revision: D6988096

Pulled By: sahrens

fbshipit-source-id: ec0ffa763245e786f44b4a1d56c0738876c25782
 		2018-02-14 08:02:48 -08:00
..
ART Fixed black ARTSurfaceView 2017-12-19 19:46:06 -08:00
ActionSheetIOS Flow Type ActionSheetIOS 2017-12-13 16:19:21 -08:00
Alert Fix duplicate var name declaration 2018-02-13 01:49:56 -08:00
Animated Verify that the component passed to createAnimatedComponent is not functional 2018-02-14 08:02:48 -08:00
AppState Migrate additional docs to the new format 2017-11-20 13:16:12 -08:00
BatchedBridge Typos in comments and log messages 2018-01-12 22:18:45 -08:00
Blob fixed blobmanager inserting nil when there's no mime type 2018-02-08 19:31:25 -08:00
BugReporting Add extra data view to RN RedBox 2017-12-14 10:50:24 -08:00
CameraRoll Trim docs that are already present in the open source docs site 2018-01-29 16:20:15 -08:00
Components Ran rename-unsafe-lifecycles codemod on xplat/js 2018-02-08 10:58:31 -08:00
Core Fix ESLint upgrade "parsing error" 2018-02-10 10:51:14 -08:00
EventEmitter RN: Improve NativeEventEmitter Flow Types 2017-10-13 08:04:17 -07:00
Experimental Ran rename-unsafe-lifecycles codemod on xplat/js 2018-02-08 10:58:31 -08:00
Geolocation Trim docs that are already present in the open source docs site 2018-01-29 16:20:15 -08:00
Image Add FDSStoryHeader 2018-02-12 18:50:21 -08:00
Inspector Ran rename-unsafe-lifecycles codemod on xplat/js 2018-02-08 10:58:31 -08:00
Interaction @allow-large-files [Flow] Upgrade xplat/js to flow v0.63 2018-01-08 12:49:53 -08:00
JSInspector Add Network agent 2016-11-02 12:29:15 -07:00
LayoutAnimation @allow-large-files Flow v0.54.0 2017-09-06 03:33:43 -07:00
Linking Trim docs that are already present in the open source docs site 2018-01-29 16:20:15 -08:00
LinkingIOS Standardize project indentation settings on 2 spaces 2017-07-31 05:20:03 -07:00
Lists Ran rename-unsafe-lifecycles codemod on xplat/js 2018-02-08 10:58:31 -08:00
Modal Ran rename-unsafe-lifecycles codemod on xplat/js 2018-02-08 10:58:31 -08:00
NativeAnimation Typos in comments and log messages 2018-01-12 22:18:45 -08:00
Network Trim docs that are already present in the open source docs site 2018-01-29 16:20:15 -08:00
Performance Add flow typing to QuickPerformanceLogger 2018-01-22 05:30:54 -08:00
PermissionsAndroid Trim docs that are already present in the open source docs site 2018-01-29 16:20:15 -08:00
PushNotificationIOS Trim docs that are already present in the open source docs site 2018-01-29 16:20:15 -08:00
RCTTest RNTester: Relax Bridge Release Check 2018-01-05 15:05:31 -08:00
ReactNative Removed ReactNativeFeatureFlags 2018-02-09 10:58:55 -08:00
Renderer React sync for revisions 467b103...a634e53 2018-02-12 14:02:30 -08:00
Sample Standardize project indentation settings on 2 spaces 2017-07-31 05:20:03 -07:00
Settings Fix infinite recursion in RCTSettingsManager init 2017-08-09 09:39:40 -07:00
Share Flow 0.59 xplat/js deploy 2017-11-10 21:15:48 -08:00
Storage Migrate additional docs to the new format 2017-11-20 13:16:12 -08:00
StyleSheet Implementing space-evenly 2018-01-31 10:17:22 -08:00
SurfaceBackedComponent RCTSurface: Couple helper functions for Stage 2017-12-03 20:16:35 -08:00
SurfaceHostingComponent Add explicit componentControllerClass to CKComponent 2018-01-10 02:48:09 -08:00
Text Fixed a bug with positioning of nested views inside <Text> 2018-02-13 23:51:54 -08:00
Types use scrollview for lightbox on ios 2018-02-01 12:13:07 -08:00
Utilities Freeze UTFSequence 2018-02-13 14:36:37 -08:00
Vibration Trim docs that are already present in the open source docs site 2018-01-29 16:20:15 -08:00
WebSocket Implement Blob support for XMLHttpRequest 2018-01-26 09:17:11 -08:00
Wrapper Yoga float vs. CoreGraphics float in RCTWrapper 2018-01-08 14:48:55 -08:00
fishhook Merge fishhook.xcodeproj in RCTWebSocket 2017-08-09 07:48:09 -07:00
polyfills Typos in comments and log messages 2018-01-12 22:18:45 -08:00
react-native Switch to `declare module.exports` syntax 2017-12-14 16:31:14 -08:00
vendor Typos in code 2018-01-29 19:17:33 -08:00
.eslintrc Disallow trailing commas in react-native-github 2017-08-17 16:20:04 -07:00
Promise.js @allow-large-files Flow v0.54.0 2017-09-06 03:33:43 -07:00
UTFSequence.js add BULLET and BULLET_SP 2018-02-13 22:17:21 -08:00
promiseRejectionIsError.js @allow-large-files Flow v0.54.0 2017-09-06 03:33:43 -07:00