react-native/local-cli/core
Jordan Brown 0ee23d0beb Remove unused suppressions in xplat/js
Summary:
There were approximately 350 unused suppressions in xplat/js when checking with .flowconfig.android

The flow team is partially responsible for this, since our release process hasn't changed since we added the flowconfig. In the diff beneath this one, I added the functionality necessary for us to not add any more unused suppressions. To test it, I made this diff. The steps were:

1. Start iOS server
2. Start android server
3. remove unused ios suppressions
4. remove unused android suppressions
5. add ios suppressions with site=react_native_ios_fb
6. add android suppressions with site=react_native_android_fb
7. remove unused ios suppressions. The ones that are unused are ones where an android comment was inserted as well, since the ios comment no longer is next to the error
8. add suppressions using ios flowconfig with site=react_native_fb
9. remove unused android suppressions. The unused ones are ones that were moved up when the cross-platform suppressions were inserted.

I'm going to make this into a script to make sure we don't contribute anymore unused suppressions from our side.

The controller you requested could not be found. nolint

Reviewed By: TheSavior

Differential Revision: D10053893

fbshipit-source-id: 7bee212062f8b2153c6ba906a30cf40df2224019
2018-09-27 11:47:04 -07:00
..
__fixtures__ react-native: make automated fs-based tests platform-independent 2018-09-17 05:46:47 -07:00
__tests__ react-native: make automated fs-based tests platform-independent 2018-09-17 05:46:47 -07:00
android Update copyright headers to yearless format 2018-09-11 15:33:07 -07:00
ios Update copyright headers to yearless format 2018-09-11 15:33:07 -07:00
Constants.js Update copyright headers to yearless format 2018-09-11 15:33:07 -07:00
findAssets.js Update copyright headers to yearless format 2018-09-11 15:33:07 -07:00
findPlugins.js Give RNPM the ability to look for plugins in `@scoped` modules (#21082) 2018-09-13 04:31:38 -07:00
index.js Remove unused suppressions in xplat/js 2018-09-27 11:47:04 -07:00
makeCommand.js Update copyright headers to yearless format 2018-09-11 15:33:07 -07:00
wrapCommands.js Update copyright headers to yearless format 2018-09-11 15:33:07 -07:00