react-native/local-cli/server/util
chunghe b0ca3ed49b close `<audio>` tag. Some debugger (ex: remote-redux-devtools-on-debu…
Summary:
[remote-redux-devtools-on-debugger](https://github.com/jhen0409/remote-redux-devtools-on-debugger) is a redux debugger UI for react-native. It inject code to debugger.html to communicate to the [Remote Redux DevTools](https://github.com/zalmoxisus/remote-redux-devtools). But the injecting failed for react-native 0.44 because the injected code will be wrapped in the audio tag. Here's the screenshot:

![2017-05-05 16 12 50](https://cloud.githubusercontent.com/assets/78242/25739567/02d7824c-31b5-11e7-99d3-36b17effaaa3.png)

The pull request close the `<audio>` tag to make sure the injecting code not wrap inside `<audio>` tag

![2017-05-05 17 13 29](https://cloud.githubusercontent.com/assets/78242/25739835/317bc698-31b6-11e7-8aab-c2ecabf1eccb.png)

`$ npm install --save-dev remote-redux-devtools-on-debugger`
`$ ./node_modules/.bin/remotedev-debugger --hostname localhost --port 5678 --injectserver`
$ open debugger.html in the browser, open the chrome dev tool, make sure the injected code not wrapped in the audio tag.

If you have added code that should be tested, add tests.

Sign the [CLA][2], if you haven't already.

Small pull requests are much easier to review and more likely to get merged. Make sure the PR does only one thing, otherwise please split it.

Make sure all **tests pass** on both [Travis][3] and [Circle CI][4]. PRs that break tests are unlikely to be merged.

For more info, see the ["Pull Requests"][5] section of our "Contributing" guidelines.

[1]: https://medium.com/martinkonicek/what-is-a-test-plan-8bfc840ec171#.y9lcuqqi9
[2]: https://code.facebook.com/cla
[3]: https://travis-ci.org/facebook/react-native
[4]: http://circleci.com/gh/facebook/react-native
[5]: https://github.com/facebook/react-native/blob/master/CONTRIBUTING.md#pull-requests
Closes https://github.com/facebook/react-native/pull/13798

Differential Revision: D5154006

Pulled By: shergin

fbshipit-source-id: bd5f1774108649774b33ff2bf38d1aee3a5c50a9
2017-05-31 02:46:21 -07:00
..
external Make copy button work on android emulator in Linux using xsel 2017-04-04 10:20:19 -07:00
attachHMRServer.js packager: DependencyGraph: remove re-exported functions 2017-05-12 10:37:03 -07:00
copyToClipBoard.js Make copy button work on android emulator in Linux using xsel 2017-04-04 10:20:19 -07:00
debugger.html close `<audio>` tag. Some debugger (ex: remote-redux-devtools-on-debu… 2017-05-31 02:46:21 -07:00
debuggerWorker.js RN: Show Warning for Background Remote Debuggers 2016-10-31 11:29:57 -07:00
inspectorProxy.js Fix Promise resolve callback error 2017-05-09 16:47:34 -07:00
jsPackagerClient.js BREAKING: Change the js1 - packager - RN App protocol to version 2 2017-02-16 04:30:00 -08:00
launchChrome.js Allow launching inspector from dev menu 2016-11-15 08:59:02 -08:00
launchEditor.js open in editor fix, show tip instead of error 2017-04-28 06:18:30 -07:00
messageSocket.js Extract PackagerConnectionSettings to ensure easier reusability of PackagerConnection module 2017-03-17 10:02:34 -07:00
webSocketProxy.js Improve Chrome debugger 2016-02-05 15:17:33 -08:00