react-native/Libraries
Shane Osbourne dbc23466b3 fix: account for `ListHeaderComponent` length when calculating offset… (#17415)
Summary:
… in VirtualizedList - fixes #16612

Issue is detailed in #16612

<!--
Thank you for sending the PR! We appreciate you spending the time to work on these changes.

Help us understand your motivation by explaining why you decided to make this change.

You can learn more about contributing to React Native here: http://facebook.github.io/react-native/docs/contributing.html

Happy contributing!

-->

I need `onViewableItemsChanged` to account for the length of any ListHeaderComponents

I couldn't find any tests that currently cover the use-case of a VirtualizedList + ListComponent + scroll with onViewableItemsChanged, so I have not added any tests - all previous tests pass however.

<!--
Help reviewers and the release process by writing your own release notes

**INTERNAL and MINOR tagged notes will not be included in the next version's final release notes.**

  CATEGORY
[----------]        TYPE
[ CLI      ]   [-------------]      LOCATION
[ DOCS     ]   [ BREAKING    ]   [-------------]
[ GENERAL  ]   [ BUGFIX      ]   [-{Component}-]
[ INTERNAL ]   [ ENHANCEMENT ]   [ {File}      ]
[ IOS      ]   [ FEATURE     ]   [ {Directory} ]   |-----------|
[ ANDROID  ]   [ MINOR       ]   [ {Framework} ] - | {Message} |
[----------]   [-------------]   [-------------]   |-----------|

[CATEGORY] [TYPE] [LOCATION] - MESSAGE

 EXAMPLES:

 [IOS] [BREAKING] [FlatList] - Change a thing that breaks other things
 [ANDROID] [BUGFIX] [TextInput] - Did a thing to TextInput
 [CLI] [FEATURE] [local-cli/info/info.js] - CLI easier to do things with
 [DOCS] [BUGFIX] [GettingStarted.md] - Accidentally a thing/word
 [GENERAL] [ENHANCEMENT] [Yoga] - Added new yoga thing/position
 [INTERNAL] [FEATURE] [./scripts] - Added thing to script that nobody will see
-->

[GENERAL][BUGFIX][VirtualizedList] - account for `ListHeaderComponent` length
Closes https://github.com/facebook/react-native/pull/17415

Differential Revision: D8683555

Pulled By: hramos

fbshipit-source-id: 05df7b79c16e3c07c12468e782f3c4b0bdce7403
2018-06-28 15:32:39 -07:00
..
ART Update Xcode projects (#19574) 2018-06-19 23:48:12 -07:00
ActionSheetIOS Update Xcode projects (#19574) 2018-06-19 23:48:12 -07:00
Alert Prettier React Native Libraries 2018-05-10 19:10:38 -07:00
Animated Flow strictify possible files in RN core 2018-06-20 00:47:21 -07:00
AppState Prettier React Native Libraries 2018-05-10 19:10:38 -07:00
BatchedBridge Eliminate circular dependency between MessageQueue and JSTimers modules. (#19526) 2018-06-15 17:06:29 -07:00
Blob Flow strictify possible files in RN core 2018-06-20 00:47:21 -07:00
BugReporting Flow strictify possible files in RN core 2018-06-20 00:47:21 -07:00
CameraRoll Update Xcode projects (#19574) 2018-06-19 23:48:12 -07:00
Color Bump Prettier to 1.13.4 on xplat 2018-06-06 05:32:06 -07:00
Components Upgrade Prettier to 1.13.6 on fbsource 2018-06-27 03:32:42 -07:00
Core Eliminate circular dependency between MessageQueue and JSTimers modules. (#19526) 2018-06-15 17:06:29 -07:00
EventEmitter Prettier React Native Libraries 2018-05-10 19:10:38 -07:00
Experimental Adding custom view to swipeable component 2018-06-21 10:33:07 -07:00
Geolocation Update Xcode projects (#19574) 2018-06-19 23:48:12 -07:00
Image Image with null source should still respect `style` 2018-06-26 11:02:10 -07:00
Inspector RN: Fix Element Inspector w/ Start + End Styles 2018-06-26 13:33:43 -07:00
Interaction RN: Remove ReactPerf References 2018-05-15 13:16:57 -07:00
JSInspector Prettier React Native Libraries 2018-05-10 19:10:38 -07:00
LayoutAnimation Remove @providesModule from all modules 2018-04-25 07:37:10 -07:00
Linking Prettier React Native Libraries 2018-05-10 19:10:38 -07:00
LinkingIOS Update Xcode projects (#19574) 2018-06-19 23:48:12 -07:00
Lists fix: account for `ListHeaderComponent` length when calculating offset… (#17415) 2018-06-28 15:32:39 -07:00
Modal Switch to Platform.isTV to pass Android Flow 2018-06-10 13:45:57 -07:00
NativeAnimation Update Xcode projects (#19574) 2018-06-19 23:48:12 -07:00
Network Update Xcode projects (#19574) 2018-06-19 23:48:12 -07:00
Performance Flow strictify possible files in RN core 2018-06-20 00:47:21 -07:00
PermissionsAndroid Prettier React Native Libraries 2018-05-10 19:10:38 -07:00
PushNotificationIOS Update Xcode projects (#19574) 2018-06-19 23:48:12 -07:00
RCTTest Update Xcode projects (#19574) 2018-06-19 23:48:12 -07:00
ReactNative Flow strictify possible files in RN core 2018-06-20 00:47:21 -07:00
Renderer React sync for revisions c0fe8d6...ae14317 2018-06-16 00:46:24 -07:00
Sample iOS OSS: deployment target 8.0 => 9.0 2018-05-22 01:16:45 -07:00
Settings Update Xcode projects (#19574) 2018-06-19 23:48:12 -07:00
Share Prettier React Native Libraries 2018-05-10 19:10:38 -07:00
Storage Prettier React Native Libraries 2018-05-10 19:10:38 -07:00
StyleSheet Flow strictify possible files in RN core 2018-06-20 00:47:21 -07:00
SurfaceBackedComponent Update license headers for MIT license 2018-02-16 18:31:53 -08:00
SurfaceHostingComponent Update license headers for MIT license 2018-02-16 18:31:53 -08:00
Text Flow strictify possible files in RN core 2018-06-20 00:47:21 -07:00
Types Flow strictify possible files in RN core 2018-06-20 00:47:21 -07:00
Utilities Flow strictify possible files in RN core 2018-06-20 00:47:21 -07:00
Vibration Update Xcode projects (#19574) 2018-06-19 23:48:12 -07:00
WebSocket - Correct fishhook import in RCTReconnectingWebSocket Fixes #16039 (#16271) 2018-06-28 11:49:32 -07:00
Wrapper Update additional license headers 2018-03-08 12:10:14 -08:00
YellowBox YellowBox: Fix Off-By-1 Content Rendering Bug 2018-06-26 13:33:42 -07:00
fishhook Merge fishhook.xcodeproj in RCTWebSocket 2017-08-09 07:48:09 -07:00
polyfills Implement console group APIs (#18555) 2018-06-12 11:18:37 -07:00
react-native Flow strictify possible files in RN core 2018-06-20 00:47:21 -07:00
vendor Upgrade Prettier to 1.13.6 on fbsource 2018-06-27 03:32:42 -07:00
.npmignore npmignore: ignore tests and fixtures 2018-02-27 08:42:14 -08:00
Promise.js Prettier React Native Libraries 2018-05-10 19:10:38 -07:00
UTFSequence.js RN: A wild YellowBox has appeared! 2018-06-11 18:31:18 -07:00
promiseRejectionIsError.js Prettier React Native Libraries 2018-05-10 19:10:38 -07:00