mirror of
https://github.com/status-im/react-native.git
synced 2025-02-06 14:43:49 +00:00
4203c9c837
Summary: The problem with `bundleOpts` is that it discards Flow typing, so it prevents reinforcing the integration of `Bundler` into `Server`. This changeset removes the `bundleOpts` to solve that issues. Instead, it makes the options explicit so that there is less uncertaintly. I love making options explicit, because they force callsites to take a consicious decision about what is really needed, making them more robust. They also expose oddities that probably needs refatoring, for example having a `resolutionRequest` in the bundle options does not seem correct, it should be an implementation details. Likewise, `onProgress` should probably be exposed differently, as it does not affect the content of the bundle itself. Reviewed By: davidaurelio Differential Revision: D4697729 fbshipit-source-id: d543870ba024e7588c10b101fa51429c77cc5ddc
47 lines
1.4 KiB
JavaScript
47 lines
1.4 KiB
JavaScript
/**
|
|
* Copyright (c) 2015-present, Facebook, Inc.
|
|
* All rights reserved.
|
|
*
|
|
* This source code is licensed under the BSD-style license found in the
|
|
* LICENSE file in the root directory of this source tree. An additional grant
|
|
* of patent rights can be found in the PATENTS file in the same directory.
|
|
*
|
|
* @flow
|
|
*/
|
|
|
|
'use strict';
|
|
|
|
const Server = require('../../../../packager/src/Server');
|
|
|
|
const asAssets = require('./as-assets');
|
|
const asIndexedFile = require('./as-indexed-file');
|
|
|
|
import type Bundle from '../../../../packager/src//Bundler/Bundle';
|
|
import type {OutputOptions, RequestOptions} from '../../types.flow';
|
|
|
|
function buildBundle(packagerClient: Server, requestOptions: RequestOptions) {
|
|
return packagerClient.buildBundle({
|
|
...Server.DEFAULT_BUNDLE_OPTIONS,
|
|
...requestOptions,
|
|
unbundle: true,
|
|
isolateModuleIDs: true,
|
|
});
|
|
}
|
|
|
|
function saveUnbundle(
|
|
bundle: Bundle,
|
|
options: OutputOptions,
|
|
log: (x: string) => void,
|
|
): Promise<mixed> {
|
|
// we fork here depending on the platform:
|
|
// while android is pretty good at loading individual assets, ios has a large
|
|
// overhead when reading hundreds pf assets from disk
|
|
return options.platform === 'android' && !options.indexedUnbundle ?
|
|
asAssets(bundle, options, log) :
|
|
asIndexedFile(bundle, options, log);
|
|
}
|
|
|
|
exports.build = buildBundle;
|
|
exports.save = saveUnbundle;
|
|
exports.formatName = 'bundle';
|