mirror of
https://github.com/status-im/react-native.git
synced 2025-01-09 17:15:54 +00:00
5db5ee9f55
Summary:
There were several fixes to how calls to propType checkers. This is to
account for the new deprecation warning - React.PropTypes will not be
part of production builds in the future.
Note: There is still a warning about an invalid argument to `React.PropTypes.oneOf` (React is running that validation sooner now). Specifically [both of these](b1e49832ef/Libraries/Components/Touchable/TouchableWithoutFeedback.js (L44-L45)) because `View.AccessibilityTraits` is actually undefined in tests (didn't look into why you conditionally set that).
**Test plan (required)**
`npm test` & fixed all warnings due to proptype secret
Closes https://github.com/facebook/react-native/pull/8758
Reviewed By: zpao
Differential Revision: D3564288
Pulled By: bestander
fbshipit-source-id: 1ff1f90907f41855e364048aa730ccd239c522b4
77 lines
2.2 KiB
JavaScript
77 lines
2.2 KiB
JavaScript
/**
|
|
* Copyright (c) 2015-present, Facebook, Inc.
|
|
* All rights reserved.
|
|
*
|
|
* This source code is licensed under the BSD-style license found in the
|
|
* LICENSE file in the root directory of this source tree. An additional grant
|
|
* of patent rights can be found in the PATENTS file in the same directory.
|
|
*
|
|
* @providesModule StyleSheetValidation
|
|
* @flow
|
|
*/
|
|
'use strict';
|
|
|
|
var ImageStylePropTypes = require('ImageStylePropTypes');
|
|
var ReactPropTypeLocations = require('react/lib/ReactPropTypeLocations');
|
|
var ReactPropTypesSecret = require('react/lib/ReactPropTypesSecret');
|
|
var TextStylePropTypes = require('TextStylePropTypes');
|
|
var ViewStylePropTypes = require('ViewStylePropTypes');
|
|
|
|
var invariant = require('fbjs/lib/invariant');
|
|
|
|
class StyleSheetValidation {
|
|
static validateStyleProp(prop, style, caller) {
|
|
if (!__DEV__) {
|
|
return;
|
|
}
|
|
if (allStylePropTypes[prop] === undefined) {
|
|
var message1 = '"' + prop + '" is not a valid style property.';
|
|
var message2 = '\nValid style props: ' +
|
|
JSON.stringify(Object.keys(allStylePropTypes).sort(), null, ' ');
|
|
styleError(message1, style, caller, message2);
|
|
}
|
|
var error = allStylePropTypes[prop](
|
|
style,
|
|
prop,
|
|
caller,
|
|
ReactPropTypeLocations.prop,
|
|
null,
|
|
ReactPropTypesSecret
|
|
);
|
|
if (error) {
|
|
styleError(error.message, style, caller);
|
|
}
|
|
}
|
|
|
|
static validateStyle(name, styles) {
|
|
if (!__DEV__) {
|
|
return;
|
|
}
|
|
for (var prop in styles[name]) {
|
|
StyleSheetValidation.validateStyleProp(prop, styles[name], 'StyleSheet ' + name);
|
|
}
|
|
}
|
|
|
|
static addValidStylePropTypes(stylePropTypes) {
|
|
for (var key in stylePropTypes) {
|
|
allStylePropTypes[key] = stylePropTypes[key];
|
|
}
|
|
}
|
|
}
|
|
|
|
var styleError = function(message1, style, caller?, message2?) {
|
|
invariant(
|
|
false,
|
|
message1 + '\n' + (caller || '<<unknown>>') + ': ' +
|
|
JSON.stringify(style, null, ' ') + (message2 || '')
|
|
);
|
|
};
|
|
|
|
var allStylePropTypes = {};
|
|
|
|
StyleSheetValidation.addValidStylePropTypes(ImageStylePropTypes);
|
|
StyleSheetValidation.addValidStylePropTypes(TextStylePropTypes);
|
|
StyleSheetValidation.addValidStylePropTypes(ViewStylePropTypes);
|
|
|
|
module.exports = StyleSheetValidation;
|