react-native/scripts
ArturKlajnerok 7d1981ef82 Removing test-driver symlink in ios third party install script
Summary:
After execution of `scripts/ios-install-third-party.sh` a symlink is created :
`<YOUR-APP-PATH>/node_modules/react-native/third-party/glog-0.3.4/test-driver`
that is pointing to `test-driver -> /usr/share/automake-1.14/test-driver`
This can be executed indirectly by `react-native run-ios`.

This breaks the bundle process if the system don't contain a given file under the link and having this strict dependency on the system setup is not a good practice.

Once the `test-driver` symlink is created android app release is failing, for :
`./gradlew assembleRelease`
the `:app:bundleReleaseJsAndAssets` returns :
```
FAILURE: Build failed with an exception.

* What went wrong:
Could not list contents of '<YOUR-APP-PATH>/node_modules/react-native/third-party/glog-0.3.4/test-driver'. Couldn't follow symbolic link.
```
Related issues:
https://github.com/facebook/react-native/issues/14417
https://github.com/facebook/react-native/issues/14464
https://github.com/facebook/react-native/issues/14548

1. Create new project with `react-native init <YOUR-APP>`
2. cd `<YOUR-APP>/`
3. Run app on iOS `react-native run-ios` so `scripts/ios-install-third-party.sh` is executed.
4. cd `android/`
5. Run android app release `./gradlew assembleRelease` (it will work properly after this fix and fail if the `test-driver` symlink exists)

IMHO we should resolve the issue with this quick fix and apply the proper fix later after the new version of `google/glog` will be released.
The proper cleanup of files generated by autotools was already applied : https://github.com/google/glog/pull/188

Please let me know if I should provide more details : javache, mhorowitz, hramos
Closes https://github.com/facebook/react-native/pull/14638

Differential Revision: D5292362

Pulled By: javache

fbshipit-source-id: 81ff2273420ea078d624a76e781a5b67b96e6a4e
2017-06-21 07:45:37 -07:00
..
android-e2e-test.js
bump-oss-version.js Fixes current CI failures and allows tree shaking of native dev support code. 2017-02-27 14:04:58 -08:00
circle-ci-android-setup.sh Updated extra-android-m2repository to get android support v4 23.4.0 2016-12-29 05:43:31 -08:00
ios-configure-glog.sh Removing test-driver symlink in ios third party install script 2017-06-21 07:45:37 -07:00
ios-install-third-party.sh Add some debug logging if tar fails 2017-06-15 13:05:05 -07:00
launchPackager.bat Move packager launcher scripts outside of `packager/` 2017-05-23 16:17:09 -07:00
launchPackager.command Move packager launcher scripts outside of `packager/` 2017-05-23 16:17:09 -07:00
objc-test-ios.sh Re-license and rename UIExplorer integration test app as RNTester 2017-05-08 11:31:19 -07:00
objc-test-tvos.sh Re-license and rename UIExplorer integration test app as RNTester 2017-05-08 11:31:19 -07:00
objc-test.sh Move packager launcher scripts outside of `packager/` 2017-05-23 16:17:09 -07:00
packager.sh Fix `scripts/packager.sh` for RNTester 2017-05-25 09:46:23 -07:00
process-podspecs.sh Make sure to run all subspecs, to find failing cases 2017-05-17 11:16:49 -07:00
publish-npm.js
react-native-xcode.sh Fix Incorrect Build Script Bash False-Matching 2017-05-26 02:45:20 -07:00
run-android-ci-instrumentation-tests.js Skip flaky ScrollView tests 2017-03-13 13:30:31 -07:00
run-android-emulator.sh Improve Android testing scripts 2016-12-13 17:13:35 -08:00
run-android-local-integration-tests.sh Skip flaky ScrollView tests 2017-03-13 13:30:31 -07:00
run-android-local-unit-tests.sh Improve Android testing scripts 2016-12-13 17:13:35 -08:00
run-ci-e2e-tests.js Add --maxWorkers flag and allow transformers to run in-band. 2017-06-13 09:16:03 -07:00
run-instrumentation-tests-via-adb-shell.sh
sync-css-layout.sh
test-manual-e2e.sh Re-license and rename UIExplorer integration test app as RNTester 2017-05-08 11:31:19 -07:00
try-n-times.js
validate-android-device-env.sh Improve Android testing scripts 2016-12-13 17:13:35 -08:00
validate-android-sdk.sh Improve Android testing scripts 2016-12-13 17:13:35 -08:00
validate-android-test-env.sh Add OSS website test, clean up test names, remove website dependency on sass 2017-03-30 15:30:41 -07:00