mirror of
https://github.com/status-im/react-native.git
synced 2025-01-27 09:45:04 +00:00
402e7eaac2
Summary: Re: javache 's suggestions from https://github.com/facebook/react-native/pull/7878. Didn't want to deal with the merge conflict so I'm opening a separate PR. Here's the original justification: If I want to set NODE_ENV to "baconator", I should be allowed to. Mutating global state that most devs assume to be immutable is just abysmal dev practice, especially since this mutation only happens when you're building for prod, not running on the simulator. To test this, run env NODE_ENV=baconator ./gradlew assembleRelease with babel-plugin-transform-inline-environment-variables in your app/.babelrc. You'll see that the final app has NODE_ENV=production. As a side note, running with babel-plugin-transform-inline-environment-variables in the top-level .babelrc crashes horribly with a compiler error. For anybody who runs into this bug and doesn't feel like waiting for this to get merged, I wrote a quick babel plugin to remove assignments to process.env, which is sufficient to fix this issue. Closes https://github.com/facebook/react-native/pull/8057 Differential Revision: D3419950 Pulled By: javache fbshipit-source-id: dc541cad0a99906433e5c14bbc93ce66b4ed325e
85 lines
2.7 KiB
JavaScript
85 lines
2.7 KiB
JavaScript
/**
|
|
* Copyright (c) 2015-present, Facebook, Inc.
|
|
* All rights reserved.
|
|
*
|
|
* This source code is licensed under the BSD-style license found in the
|
|
* LICENSE file in the root directory of this source tree. An additional grant
|
|
* of patent rights can be found in the PATENTS file in the same directory.
|
|
*/
|
|
|
|
const log = require('../util/log').out('bundle');
|
|
const outputBundle = require('./output/bundle');
|
|
const path = require('path');
|
|
const Promise = require('promise');
|
|
const saveAssets = require('./saveAssets');
|
|
const Server = require('../../packager/react-packager/src/Server');
|
|
|
|
function saveBundle(output, bundle, args) {
|
|
return Promise.resolve(
|
|
output.save(bundle, args, log)
|
|
).then(() => bundle);
|
|
}
|
|
|
|
function buildBundle(args, config, output = outputBundle, packagerInstance) {
|
|
return new Promise((resolve, reject) => {
|
|
|
|
// This is used by a bazillion of npm modules we don't control so we don't
|
|
// have other choice than defining it as an env variable here.
|
|
if (!process.env.NODE_ENV) {
|
|
// If you're inlining environment variables, you can use babel to remove
|
|
// this line:
|
|
// https://www.npmjs.com/package/babel-remove-process-env-assignment
|
|
process.env.NODE_ENV = args.dev ? 'development' : 'production';
|
|
}
|
|
|
|
const options = {
|
|
projectRoots: config.getProjectRoots(),
|
|
assetRoots: config.getAssetRoots(),
|
|
blacklistRE: config.getBlacklistRE(args.platform),
|
|
getTransformOptionsModulePath: config.getTransformOptionsModulePath,
|
|
transformModulePath: path.resolve(args.transformer),
|
|
extraNodeModules: config.extraNodeModules,
|
|
nonPersistent: true,
|
|
resetCache: args['reset-cache'],
|
|
};
|
|
|
|
const requestOpts = {
|
|
entryFile: args['entry-file'],
|
|
sourceMapUrl: args['sourcemap-output'],
|
|
dev: args.dev,
|
|
minify: !args.dev,
|
|
platform: args.platform,
|
|
};
|
|
|
|
// If a packager instance was not provided, then just create one for this
|
|
// bundle command and close it down afterwards.
|
|
var shouldClosePackager = false;
|
|
if (!packagerInstance) {
|
|
packagerInstance = new Server(options);
|
|
shouldClosePackager = true;
|
|
}
|
|
|
|
const bundlePromise = output.build(packagerInstance, requestOpts)
|
|
.then(bundle => {
|
|
if (shouldClosePackager) {
|
|
packagerInstance.end();
|
|
}
|
|
return saveBundle(output, bundle, args);
|
|
});
|
|
|
|
// Save the assets of the bundle
|
|
const assets = bundlePromise
|
|
.then(bundle => bundle.getAssets())
|
|
.then(outputAssets => saveAssets(
|
|
outputAssets,
|
|
args.platform,
|
|
args['assets-dest']
|
|
));
|
|
|
|
// When we're done saving bundle output and the assets, we're done.
|
|
resolve(assets);
|
|
});
|
|
}
|
|
|
|
module.exports = buildBundle;
|