status-im
/
react-native
mirror of https://github.com/status-im/react-native.git
2
0
Fork 0
Code Issues Projects Releases Wiki Activity
react-native/Libraries
History
Jeff Chien e438954938 Modify TouchableNativeFeedback (Ripple) to follow borderRadius 
Summary:Using TouchableNativeFeedback has been a problem for me because the ripples it makes don't follow the child view's border radii so the ripples stick out of the child view's rounded corners. This PR should fix this problem with a minor caveat: this only works for TouchableNativeFeedback.Ripple and not TouchableNativeFeedback.SelectableBackground. I searched how I could apply corner radius to selectableItemBackground and it doesn't seem to be possible (the prevalent advice is to create the ripple manually which is equivalent to using TNF.Ripple in our case), though I could be wrong.

I added [an example to UIExplorer (TouchableExample)](http://i.imgur.com/CHY9xjW.png). This is my first PR to this repo so let me know if something's wrong. Cheers!
Closes https://github.com/facebook/react-native/pull/6515

Differential Revision: D3126513

Pulled By: mkonicek

fb-gh-sync-id: 1d3e92243abf9706132ae47c485d9e04a9b47d81
fbshipit-source-id: 1d3e92243abf9706132ae47c485d9e04a9b47d81
 		2016-04-22 09:07:50 -07:00
..
ART Update the Spectrum downstream and add the new cloneWithProps dependency 2016-04-13 17:11:38 -07:00
ActionSheetIOS CHORE - Remove Trailing Spaces 2016-04-06 09:21:53 -07:00
AdSupport Text highlighting on iOS 2015-07-24 08:41:58 -08:00
Animated Support for stopping animations that run on UI thread. 2016-04-22 00:02:25 -07:00
AppRegistry Fix some warnings. 2016-04-20 20:45:22 -07:00
AppState Remove knowledge of fbjs from the packager 2016-03-02 04:28:38 -08:00
AppStateIOS Updating AppState to support the inactive state. 2016-03-10 08:30:24 -08:00
BatchedBridge Make object properties in NativeModules configurable. 2016-04-11 07:57:28 -07:00
BugReporting cleanup and open source JS BugReporting module 2016-04-20 08:09:07 -07:00
CameraRoll fix warning about async CameraRoll.getPhotos 2016-03-18 10:21:23 -07:00
Components Modify TouchableNativeFeedback (Ripple) to follow borderRadius 2016-04-22 09:07:50 -07:00
CustomComponents Fix or suppress errors in react-native 2016-04-21 19:47:24 -07:00
DebugComponentHierarchy Move React Core Integration to a Dependency 2016-04-21 09:28:23 -07:00
Device Decouple Module System from Native Calls 2015-12-08 16:03:37 -08:00
Devtools Move React Core Integration to a Dependency 2016-04-21 09:28:23 -07:00
Experimental Fix or suppress errors in react-native 2016-04-21 19:47:24 -07:00
Fetch Reject promise if network request failed 2016-03-08 16:37:24 -08:00
Geolocation Copy comment from LocationModule.java to Geolocation.js 2016-04-13 07:53:23 -07:00
Image Added support for Image corner radii in Android 2016-04-13 07:42:20 -07:00
Inspector Move React Core Integration to a Dependency 2016-04-21 09:28:23 -07:00
Interaction Better Incremental/TaskQueue error reporting 2016-04-05 02:35:22 -07:00
JavaScriptAppEngine Setup RCTNativeAppEventEmitter on init 2016-03-15 03:45:33 -07:00
LayoutAnimation Remove knowledge of fbjs from the packager 2016-03-02 04:28:38 -08:00
Linking Mention native code in `Linking` docs 2016-04-20 19:23:19 -07:00
LinkingIOS Remove knowledge of fbjs from the packager 2016-03-02 04:28:38 -08:00
Modal Fix or suppress errors in react-native 2016-04-21 19:47:24 -07:00
NativeApp Decouple Module System from Native Calls 2015-12-08 16:03:37 -08:00
NavigationExperimental Fix or suppress errors in react-native 2016-04-21 19:47:24 -07:00
Network Add support for ontimeout and onerror handler when using XMLHttpRequest for Android and iOS 2016-04-15 05:17:21 -07:00
Picker Add position to Picker onValueChange's call 2016-02-19 06:50:33 -08:00
PullToRefresh Fix red screen due to ref being undefined in PullRefreshViewAndroid 2016-04-19 06:58:22 -07:00
PushNotificationIOS Updated documentation of local notifications for PushNotificationIOS addEventListener() 2016-04-01 09:56:24 -07:00
QuickPerformanceLogger added QPL for main interactions 2015-09-29 22:25:23 -07:00
RCTTest CHORE - Remove Trailing Spaces 2016-04-06 09:21:53 -07:00
RKBackendNode Move React Core Integration to a Dependency 2016-04-21 09:28:23 -07:00
ReactIOS Fix or suppress errors in react-native 2016-04-21 19:47:24 -07:00
ReactNative Move React Core Integration to a Dependency 2016-04-21 09:28:23 -07:00
Sample Remove knowledge of fbjs from the packager 2016-03-02 04:28:38 -08:00
Settings Remove knowledge of fbjs from the packager 2016-03-02 04:28:38 -08:00
Storage Update AsyncStorage.js 2016-04-10 18:02:20 -07:00
StyleSheet Add a missing parenthese 2016-03-30 10:04:54 -07:00
Text Fix autocomplete in rich-text editing mode for CJK text input 2016-04-21 12:10:25 -07:00
Utilities Move React Core Integration to a Dependency 2016-04-21 09:28:23 -07:00
Vibration Add support for vibration patterns 2016-03-29 21:45:20 -07:00
WebSocket Add support for sending binary data in websockets 2016-04-20 08:53:25 -07:00
react-native Fix or suppress errors in react-native 2016-04-21 19:47:24 -07:00
vendor Move React Core Integration to a Dependency 2016-04-21 09:28:23 -07:00
Promise.js Remove knowledge of fbjs from the packager 2016-03-02 04:28:38 -08:00
promiseRejectionIsError.js Add possibility to `console.error`/redbox on promise rejections 2016-03-15 05:22:22 -07:00