mirror of https://github.com/status-im/react-native.git synced 2025-02-11 00:46:32 +00:00

History

Adam Comella da8759c610 Android: Fix handling of line height with inline images

Summary:
This PR was split from a commit originally in #8619. /cc dmmiller

When an inline image was larger than the specified line height,
the image would be clipped. This changes the behavior so
that the line height is changed to make room for the inline
image. This is consistent with the behavior of RN for iOS.

Here's how the change works.

ReactTextView now receives its line height from the layout thread
rather than directly from JavaScript.

The reason is that the layout thread may pick a different line height.
In the case that the tallest inline image is larger than the line
height supplied by JavaScript, we want to use that image's height as
the line height rather than the supplied line height.

Also fixed a bug where the image, which is supposed to be baseline
aligned, would be positioned at the wrong y location. To fix this,
we use `y` (the baseline) in the `draw` method rather than trying
to calculate the baseline from `bottom`. For more information
see https://code.google.com/p/andro
Closes https://github.com/facebook/react-native/pull/8907

Differential Revision: D3592781

Pulled By: dmmiller

2016-12-19 13:40:29 -08:00

libs

Add BUCK files

2016-01-22 16:20:13 +00:00

src

Android: Fix handling of line height with inline images

2016-12-19 13:40:29 -08:00

.npmignore

Don't publish /ReactAndroid/build to npm, update version on master

2015-10-12 11:11:40 -07:00

build.gradle

boost is downloaded from https://github.com/react-native-community/boost