status-im
/
react-native
mirror of https://github.com/status-im/react-native.git
2
0
Fork 0
Code Issues Projects Releases Wiki Activity
react-native/Libraries/NativeAnimation
History
Janic Duplessis c47759a9ae Fix potential retain cycles in Animated iOS 
Summary:
Fixes potential retain cycles detected by an internal fb tool.

```
First:

__NSDictionaryM
-> RCTPropsAnimatedNode
-> _parentNodes -> __NSDictionaryM
-> RCTStyleAnimatedNode
-> _childNodes -> __NSDictionaryM

Second:

RCTScrollView
-> _eventDispatcher -> RCTEventDispatcher
-> _observers -> __NSArrayM
-> RCTNativeAnimatedModule
-> _nodesManager -> RCTNativeAnimatedNodesManager
-> _uiManager -> RCTUIManager
-> _viewRegistry -> __NSDictionaryM
-> RCTScrollView
```

First fix:
Use weak map for parent and child nodes, strong refs are managed by RCTNativeAnimatedNodesManager

Second fix:
Make RCTEventDispatcher observers a weak array and make sure we don't keep strong refs to UIManager in RCTNativeAnimatedNodesManager and RCTPropsAnimatedNode.

Tested that native animations still work in UIExplorer

[IOS] [BUGFIX] [NativeAnimated] - Fix potential retain cycles in Animated iOS
Closes https://github.com/facebook/react-native/pull/16506

Differential Revision: D6126400

Pulled By: shergin

fbshipit-source-id: 1ac5083f8ab79a806305edc23ae4796ed428f78b
 		2017-10-23 13:20:59 -07:00
..
Drivers Add closed-form damped harmonic oscillator algorithm to Animated.spring 2017-09-20 23:38:16 -07:00
Nodes Fix potential retain cycles in Animated iOS 2017-10-23 13:20:59 -07:00
RCTAnimation.xcodeproj Standardize project indentation settings on 2 spaces 2017-07-31 05:20:03 -07:00
RCTAnimationUtils.h Native Animated - Add tests on iOS 2017-03-28 09:16:58 -07:00
RCTAnimationUtils.m Native Animated - Add tests on iOS 2017-03-28 09:16:58 -07:00
RCTNativeAnimatedModule.h Bunch of utility funcs were moved to RCTUIManagerUtils 2017-09-26 14:08:28 -07:00
RCTNativeAnimatedModule.m Native Animated - Allow events that are dispatched from any thread 2017-09-25 23:15:15 -07:00
RCTNativeAnimatedNodesManager.h Native Animations - Fix edge case with restore default values 2017-05-25 06:18:36 -07:00
RCTNativeAnimatedNodesManager.m Fix potential retain cycles in Animated iOS 2017-10-23 13:20:59 -07:00