react-native

mirror of https://github.com/status-im/react-native.git synced 2025-01-09 17:15:54 +00:00

History

Simon Dohmen d73446c549 Fixed position of ripple-effect

Summary:
I recognised that the ripple effect was always located at the bottom of my buttons. So i started to search for other ppl having the same problem. I also found this bug on the f8 app.

The gifs show the behaviour before and after my changes:

[The ripple effect is always on the bottom of the element, because pageY is used instead of the relative pos]
![before](https://cloud.githubusercontent.com/assets/956410/16042805/df49d97e-323c-11e6-8ce2-b0658ec85b27.gif)

![after](https://cloud.githubusercontent.com/assets/956410/16042804/df483a60-323c-11e6-862f-e8c97b835339.gif)

Before, the absolute position of the touch was used to update the position during movement but it should be the relative position. Just some small calculation changes were needed to achieve the correct behaviour :)
Closes https://github.com/facebook/react-native/pull/8111

Differential Revision: D3539652

fbshipit-source-id: dd8c8f3c7402d0d435f1c2ca67c1a59b474efda3

2016-07-08 19:33:20 -07:00

__tests__

Remove node_modules/react from the list of discoverable haste modules

2016-07-05 06:44:33 -07:00

BoundingDimensions.js

Remove node_modules/react from the list of discoverable haste modules

2016-07-05 06:44:33 -07:00

ensureComponentIsNative.js

Remove knowledge of fbjs from the packager

2016-03-02 04:28:38 -08:00

ensurePositiveDelayProps.js

Remove knowledge of fbjs from the packager