mirror of https://github.com/status-im/react-native.git synced 2025-01-28 10:14:49 +00:00

History

Sergei Dryganets d5e3f081c6 Fix #6228 : Crash in Android dialog module.

Summary:
Android dialog module has a race condition as a result of which it crashes.
See this issue:
https://github.com/facebook/react-native/issues/6228.

The mIsInForeground flag is set on UI thread but was used from the ReactMethod thread.
Now all public methods of FragmentManagerHelper called from UI thread only.
Asserts are added in appropriate places to prevent future regressions.

Make sure that dialogs work after this change.
It will be nearly impossible to reproduce the issue manually but automatic regression tests should be able to catch this. At least our tests were crashing on some dialog scenarios from time to time.

[ANDROID] [MINOR] [BUGFIX] - Race condition fix in Android Dialogs module.
Closes https://github.com/facebook/react-native/pull/17392

Reviewed By: achen1

Differential Revision: D6708787

Pulled By: mdvacca

fbshipit-source-id: 99beb3ea3046286cc973f7677e98ff36f162b09b

2018-01-11 18:57:31 -08:00

libs

Add include_defs("//ReactAndroid/DEFS") to all BUCK files in ReactAndroid

2017-09-29 16:16:06 -07:00

src

Fix #6228 : Crash in Android dialog module.

2018-01-11 18:57:31 -08:00

.npmignore

…

build.gradle

Update OSS Fresco dependency

2017-07-12 07:54:09 -07:00