status-im
/
react-native
mirror of https://github.com/status-im/react-native.git
2
0
Fork 0
Code Issues Projects Releases Wiki Activity
react-native/Libraries
History
Peter Pistorius 185948604c Fix scalesPageToFit default property for iOS WebView. 
Summary:
`scalesPageToFit`'s [documented default value is true](https://github.com/facebook/react-native/blob/master/Libraries/Components/WebView/WebView.ios.js#L318), but it's not explicitly set anywhere on iOS. On Android it's [set to true in defaultProps](https://github.com/facebook/react-native/blob/master/Libraries/Components/WebView/WebView.android.js#L203). This pull-request add the default behaviour.

```
import { WebView } from 'react-native;
/* ... */
<WebView source={{ uri: 'https://google.com' }} />
```

You should be able to zoom in and out using the pinch gesture.

1. Does the reviewer have any additional thoughts around the rest of the defaultProps which aren't explicitly set?
2. Does the reviewer have any additional thoughts on how these two components (iOS/ Android) can share more code?
Closes https://github.com/facebook/react-native/pull/14363

Differential Revision: D5345883

Pulled By: shergin

fbshipit-source-id: e7b9b89f13d6adcdc705244871e00b7a5da52c64
 		2017-06-29 01:00:39 -07:00
..
ART call toString on fontWeight else throws error if passed an integer 2017-05-25 01:34:53 -07:00
ActionSheetIOS Enable -Wimplicit-retain-self en sync warning config for all projects 2017-03-23 15:01:34 -07:00
AdSupport Update AdSupportIOS.js 2017-04-28 06:34:21 -07:00
Alert Export Alert's type ButtonsArray for external use 2017-03-06 12:44:47 -08:00
Animated remove disableAutomock from jest tests (new default) @bypass-lint 2017-06-13 15:04:09 -07:00
AppState Added stubs for some native modules 2017-06-01 08:31:19 -07:00
BatchedBridge Allow no args to be passed to rejection callback 2017-06-22 10:04:09 -07:00
BugReporting Patch up for future React Sync 2017-02-08 14:50:43 -08:00
CameraRoll Update remaining PropTypes references 2017-06-12 16:03:09 -07:00
Components Fix scalesPageToFit default property for iOS WebView. 2017-06-29 01:00:39 -07:00
Core Codemod prettier to 1.5.2 2017-06-28 12:50:30 -07:00
DebugComponentHierarchy Move React Core Integration to a Dependency 2016-04-21 09:28:23 -07:00
EventEmitter Allow lazy modules registration with the BatchedBridge 2017-06-06 07:07:19 -07:00
Experimental Remove RN fiber createClass wrapper around View 2017-06-21 12:38:06 -07:00
Geolocation fix error caused by first argument short when calling warning function 2017-06-22 08:46:43 -07:00
Image ImageBackground: use cached styles 2017-06-19 08:46:32 -07:00
Inspector Fix reference to invariant 2017-06-19 08:46:32 -07:00
Interaction Move jest to version 20 2017-06-14 12:48:22 -07:00
JSInspector Add Network agent 2016-11-02 12:29:15 -07:00
LayoutAnimation Fix prop-types warning in LayoutAnimation 2017-05-12 15:06:17 -07:00
Linking Add newly recommended method for RCTLinkingManager due to deprecation 2017-05-25 11:31:23 -07:00
LinkingIOS Add newly recommended method for RCTLinkingManager due to deprecation 2017-05-25 11:31:23 -07:00
Lists Codemod prettier to 1.5.2 2017-06-28 12:50:30 -07:00
Modal iOS `presentationStyle` Modal Appearance 2017-06-20 19:22:57 -07:00
NativeAnimation Native Animated - Support Animated.loop on iOS 2017-05-26 03:30:33 -07:00
Network remove disableAutomock from jest tests (new default) @bypass-lint 2017-06-13 15:04:09 -07:00
Performance Remove unused RCTRenderingPerf 2017-06-22 09:01:04 -07:00
PermissionsAndroid Include Create React Native App in Getting Started 2017-04-26 07:16:18 -07:00
PushNotificationIOS Expose content-available APS key for iOS silent push 2017-06-19 16:46:31 -07:00
RCTTest Fixing compiler warning 2017-06-05 23:30:34 -07:00
ReactNative Codemod prettier to 1.5.2 2017-06-28 12:50:30 -07:00
Renderer React sync for revisions 4aea7c3...cb32253 2017-06-26 15:15:59 -07:00
Sample Fix missing RCTBridgeModule.h 2017-01-31 11:13:50 -08:00
Settings Enable -Wimplicit-retain-self en sync warning config for all projects 2017-03-23 15:01:34 -07:00
Share Flowify Process Color 2017-04-26 11:31:56 -07:00
Storage correctly order ASyncStorage 2017-02-21 15:18:40 -08:00
StyleSheet Refined type for `display` style property 2017-06-20 17:16:46 -07:00
Text Support `<TextInput keyboardType="numeric" returnKeyType="done" />` on iOS 2017-06-27 16:22:45 -07:00
Utilities remove disableAutomock from jest tests (new default) @bypass-lint 2017-06-13 15:04:09 -07:00
Vibration Enable -Wimplicit-retain-self en sync warning config for all projects 2017-03-23 15:01:34 -07:00
WebSocket Make startup errors in the websocket executor invalidate the bridge 2017-06-22 08:37:13 -07:00
react-native RN: Expose `unstable_batchedUpdates` on react-native 2017-06-21 00:47:08 -07:00
vendor RN: Remove lodash (Attempt 2) 2017-06-16 18:15:17 -07:00
Promise.js Don't require prettyFormat in every single bundle. 2017-06-16 04:31:56 -07:00
promiseRejectionIsError.js RN: Cleanup OSS JS & Flow Declarations 2016-11-20 17:58:29 -08:00