mirror of
https://github.com/status-im/react-native.git
synced 2025-01-09 09:12:02 +00:00
1e52ef23e7
Summary: Hi, While implementing my own `RCTURLRequestHandler` I came across retain cycles in `RCTNetworkTask` when used with `RCTFileRequestHandler` and `RCTDataRequestHandler`. The `NSBlockOperation` used in `RCTFileRequestHandler` and `RCTDataRequestHandler` could never be dealloc'ed because of a retain cycle. And then the second issue was that those blocks were also strongly capturing the passed delegate which in this case is the `RCTNetworkTask` itself and then since the task was storing the block as a `requestToken`, the task could never be dealloc'ed as well. Here are my proposed fixes. Let me know what you think. Closes https://github.com/facebook/react-native/pull/3884 Reviewed By: svcscm Differential Revision: D2615353 Pulled By: nicklockwood fb-gh-sync-id: a73cbecffbebea75aaeb23d39f04a0d87602926f
76 lines
2.1 KiB
Objective-C
76 lines
2.1 KiB
Objective-C
/**
|
|
* Copyright (c) 2015-present, Facebook, Inc.
|
|
* All rights reserved.
|
|
*
|
|
* This source code is licensed under the BSD-style license found in the
|
|
* LICENSE file in the root directory of this source tree. An additional grant
|
|
* of patent rights can be found in the PATENTS file in the same directory.
|
|
*/
|
|
|
|
#import "RCTDataRequestHandler.h"
|
|
|
|
@implementation RCTDataRequestHandler
|
|
{
|
|
NSOperationQueue *_queue;
|
|
}
|
|
|
|
RCT_EXPORT_MODULE()
|
|
|
|
- (void)invalidate
|
|
{
|
|
[_queue cancelAllOperations];
|
|
_queue = nil;
|
|
}
|
|
|
|
- (BOOL)canHandleRequest:(NSURLRequest *)request
|
|
{
|
|
return [request.URL.scheme caseInsensitiveCompare:@"data"] == NSOrderedSame;
|
|
}
|
|
|
|
- (NSOperation *)sendRequest:(NSURLRequest *)request
|
|
withDelegate:(id<RCTURLRequestDelegate>)delegate
|
|
{
|
|
// Lazy setup
|
|
if (!_queue) {
|
|
_queue = [NSOperationQueue new];
|
|
_queue.maxConcurrentOperationCount = 2;
|
|
}
|
|
|
|
__weak __block NSBlockOperation *weakOp;
|
|
__block NSBlockOperation *op = [NSBlockOperation blockOperationWithBlock:^{
|
|
|
|
// Get mime type
|
|
NSRange firstSemicolon = [request.URL.resourceSpecifier rangeOfString:@";"];
|
|
NSString *mimeType = firstSemicolon.length ? [request.URL.resourceSpecifier substringToIndex:firstSemicolon.location] : nil;
|
|
|
|
// Send response
|
|
NSURLResponse *response = [[NSURLResponse alloc] initWithURL:request.URL
|
|
MIMEType:mimeType
|
|
expectedContentLength:-1
|
|
textEncodingName:nil];
|
|
|
|
[delegate URLRequest:weakOp didReceiveResponse:response];
|
|
|
|
// Load data
|
|
NSError *error;
|
|
NSData *data = [NSData dataWithContentsOfURL:request.URL
|
|
options:NSDataReadingMappedIfSafe
|
|
error:&error];
|
|
if (data) {
|
|
[delegate URLRequest:weakOp didReceiveData:data];
|
|
}
|
|
[delegate URLRequest:weakOp didCompleteWithError:error];
|
|
}];
|
|
|
|
weakOp = op;
|
|
[_queue addOperation:op];
|
|
return op;
|
|
}
|
|
|
|
- (void)cancelRequest:(NSOperation *)op
|
|
{
|
|
[op cancel];
|
|
}
|
|
|
|
@end
|