status-im
/
react-native
mirror of https://github.com/status-im/react-native.git
2
0
Fork 0
Code Issues Projects Releases Wiki Activity
react-native/Libraries
History
Nick Lockwood 799168929c Unify XCAsset handling logic 
Summary: @​public

This diff unifies the logic for detecting when images refer to XCAsset files into a single function (RCTXCAssetNameForURL) and uses it for both +[RCTConvert UIImage:] and RCTImageLoader.

I've also tightened the definition of XCAssets so that it only applies to images inside .car files, not any image inside the main bundle. This avoids using the +[UIImage imageNamed:] when not strictly necessary, which is desirable since that method is not thread-safe, and has undocumented caching behavior that is difficult to reason about.

Reviewed By: @javache

Differential Revision: D2526400

fb-gh-sync-id: 7199c2a44f1d55ff236d2c38a0a9368739b993d5
 		2015-10-12 04:15:27 -07:00
..
ART Refactor RCTUIManager 2015-08-06 15:49:35 -08:00
ActionSheetIOS App Extension support 2015-09-22 10:46:26 -07:00
AdSupport Text highlighting on iOS 2015-07-24 08:41:58 -08:00
Animated Fix errors in preparation for v0.17.0 2015-10-07 12:03:20 -07:00
AppRegistry [React Native] Provide a way to get a list of registered apps in AppRegistry 2015-08-07 11:05:25 -08:00
AppStateIOS revert D2372548 to fix initial app state issue 2015-09-25 13:25:26 -07:00
BatchedBridge Adding jest tests to groups rn 2015-08-31 17:35:47 -08:00
CameraRoll RC Fix storyline cannot open bug (iOS 7) 2015-09-29 09:21:55 -07:00
Components Fix typo - Remove duplicated "to have" 2015-10-11 21:14:54 -07:00
CustomComponents Export per-platform NavigatorNavigationBarStyles for consistent styling 2015-10-10 15:32:46 -07:00
DebugComponentHierarchy [ReactNative] Send debug component ownership info in createView 2015-06-25 05:47:24 -08:00
Device flowify some Libraries 2015-03-25 11:09:54 -08:00
Devtools [Flow] Clean up react-native for Flow v0.15.0 2015-09-04 16:51:18 -08:00
Fetch Better feature detection for FormData/FileReader/Blob 2015-09-22 13:53:24 -07:00
Geolocation Ran Convert > To Modern Objective C Syntax 2015-08-25 01:08:49 -08:00
Image Unify XCAsset handling logic 2015-10-12 04:15:27 -07:00
Inspector [react-native] enable react devtools from JavascriptCore 2015-07-23 17:14:09 -08:00
Interaction InteractionManager: remove dev timeout warnings 2015-07-01 04:51:28 -08:00
JavaScriptAppEngine Preserve original global properties when polyfilling them 2015-10-09 14:41:23 -07:00
LayoutAnimation [ReactNative] Remove POPAnimation 2015-08-20 22:24:28 -07:00
LinkingIOS App Extension support 2015-09-22 10:46:26 -07:00
Modal Explanation of Modal's purpose in hybrid apps 2015-09-27 23:48:22 -07:00
NativeApp [ReactNative] Add "RCTNativeAppEventEmitter" 2015-05-15 16:57:18 -08:00
Network Unify XCAsset handling logic 2015-10-12 04:15:27 -07:00
Picker Fixed PickerIOS onChange event 2015-09-08 03:34:33 -08:00
Portal [RN] add clarifying Android-only comment to Portal 2015-08-31 11:10:45 -08:00
PushNotificationIOS Fix for IOS 8 2015-09-30 21:02:31 -07:00
QuickPerformanceLogger added QPL for main interactions 2015-09-29 22:25:23 -07:00
RCTTest Log React warnings internally, fix warnings in Android tests 2015-10-09 09:33:24 -07:00
RKBackendNode [ReactNative] clean lint in all of Libraries/ 2015-05-19 13:47:04 -08:00
ReactIOS Document NativeMethodsMixin 2015-10-07 09:43:22 -07:00
ReactNative Add List of Common Cases to AttributePayload Benchmark 2015-10-09 14:31:23 -07:00
Sample Remove invariant of Sample.ios.js that is not used 2015-05-26 18:25:00 -07:00
Settings Text highlighting on iOS 2015-07-24 08:41:58 -08:00
Storage Get back 100% in sync with fb codebase 2015-09-16 10:30:53 -07:00
StyleSheet Refactor Attribute Processing (Step 3) 2015-10-06 15:36:32 -07:00
Text Implemented inline image support for <Text> 2015-10-08 11:56:25 -07:00
Utilities Fix ReactPerf markers in Systrace 2015-10-01 15:05:28 -07:00
Vibration Text highlighting on iOS 2015-07-24 08:41:58 -08:00
WebSocket Implement WebSocket module for Android. Fixes #2837 2015-10-07 08:36:22 -07:00
react-native Open source ViewPagerAndroid 2015-10-06 20:01:21 -07:00
vendor Make processColor more efficient 2015-10-05 10:15:34 -07:00
Promise.js Replace ES6Promise with Promise 2015-04-15 06:06:29 -08:00