status-im
/
react-native
mirror of https://github.com/status-im/react-native.git
2
0
Fork 0
Code Issues Projects Releases Wiki Activity
react-native/local-cli/core
History
Daniel Friesen 1ad08aa659 Fix `react-native link` issue when using multiple manifests 
Summary:
`react-native link` often fails due to the wrong manifest being used when you use a debug manifest. `findManifest` returns `debug/AndroidManifest.xml` instead of `main/AndroidManifest.xml`. And the debug manifest usually does not have the package name defined so `projectConfigAndroid` throws a cryptic "Cannot read property 'replace' of undefined" error.

This fixes the issue by throwing a more user friendly error and providing a `manifestPath` userConfig.

This is mostly based on comments to #10050.
Closes https://github.com/facebook/react-native/pull/13373

Differential Revision: D4945690

Pulled By: shergin

fbshipit-source-id: b177f916fd4799c873d2515c18cbb87bef3203f0
 		2017-06-06 14:20:06 -07:00
..
__fixtures__ Fix `react-native link` issue when using multiple manifests 2017-06-06 14:20:06 -07:00
__tests__ Fix `react-native link` issue when using multiple manifests 2017-06-06 14:20:06 -07:00
android Fix `react-native link` issue when using multiple manifests 2017-06-06 14:20:06 -07:00
ios Merge `rnpm config` with the `cli config`, step 1 2017-01-09 07:58:33 -08:00
windows Merge `rnpm config` with the `cli config`, step 1 2017-01-09 07:58:33 -08:00
default.config.js Stronger config types 2017-05-03 06:51:47 -07:00
findAssets.js Merge `rnpm config` with the `cli config`, step 1 2017-01-09 07:58:33 -08:00
findPlugins.js Fix lint in local-cli 2016-11-14 11:13:42 -08:00
index.js Resolve path at callsite rather than in `Config.loadFile` 2017-05-03 06:51:47 -07:00
makeCommand.js Fix lint in local-cli 2016-11-14 11:13:42 -08:00
wrapCommands.js Merge `rnpm config` with the `cli config`, step 1 2017-01-09 07:58:33 -08:00