History

Valentin Shergin cdea3c574b Fixed crash in ReactTextInputLocalData Summary: Motivation: (SUDDENLY) There is a thing on Android called SpanWather, and their purpose is to notify "the watcher" about span-related changes in SpannableString. The idea is: some special kind of span can have some logic to prevent or tweak interleaving with some another kind of spans. To do so, it has to implement SpanWather interface. So, EditText uses this to control internal spannable object (!) and SUDDENLY (＃＞＜) calls internal "layout" method as a reaction to adding new spans. So, when we are cloning SpannableString, we are (re)applying same span objects to a new spannable instance, and it causes notifying other spans in the string, and they notify EditText, and the EditText does relayout and... BOOM! So, the solution is, easy, we should use SpannableStringBuilder instead of SpannableString because it does not notify SpanWather during cloning. See: https://android.googlesource.com/platform/frameworks/base/+/master/core/java/android/text/SpannableStringBuilder.java#101 (the first argument is `false`). https://android.googlesource.com/platform/frameworks/base/+/master/core/java/android/text/SpannableStringBuilder.java#678 Compare with: https://android.googlesource.com/platform/frameworks/base/+/master/core/java/android/text/SpannableStringInternal.java#43 Why? I believe because SpannableStringBuilder objects are "unfinished" by design, and documentation said: "it is the caller's responsibility to restore invariants [among spans]". As we do an exact clone of the string, that's perfectly okay to assume that all invariants were already satisfied for original string. Reviewed By: achen1 Differential Revision: D5970940 fbshipit-source-id: 590ca0e3aede4470b809c7db527c5d55ddf5edb4		2017-10-03 17:37:45 -07:00
..
libs	Add include_defs("//ReactAndroid/DEFS") to all BUCK files in ReactAndroid	2017-09-29 16:16:06 -07:00
src	Fixed crash in ReactTextInputLocalData	2017-10-03 17:37:45 -07:00
.npmignore	Don't publish /ReactAndroid/build to npm, update version on master	2015-10-12 11:11:40 -07:00
DEFS	Migrate to Circle 2.0	2017-09-21 14:01:30 -07:00
DevExperience.md	CHORE - Remove Trailing Spaces	2016-04-06 09:21:53 -07:00
README.md	Add scripts for running tests locally	2016-05-04 08:58:18 -07:00
build.gradle	Update OSS Fresco dependency	2017-07-12 07:54:09 -07:00
gradle.properties	fixed mockito version	2016-10-04 10:43:35 -07:00
release.gradle	Circle CI releases now work with Java 8	2016-10-28 07:58:52 -07:00

README.md

Building React Native for Android

See the docs on the website.

Running tests

When you submit a pull request CircleCI will automatically run all tests. To run tests locally, see Testing.