mirror of
https://github.com/status-im/react-native.git
synced 2025-01-10 17:45:59 +00:00
cd1a86db36
Summary: There are a couple of buggy behaviors in the current implementation of the `ellipsizeMode` prop on Android: - Setting the `numberOfLines` prop stomps on whatever value you provided for `ellipsizeMode` earlier. - The value you've provided for `ellipsizeMode` is used even if you've configured your view to have an unlimited size (i.e. `numberOfLines` is 0 or unspecified). This change fixes these issues which makes Android's `ellipsizeMode` prop more consistent with iOS's. Additionally, it renames LineBreakMode to EllipsizeMode in a couple of places. **Test plan (required)** Verified that the `numberOfLines` and `ellipsizeMode` props work correctly in an Android test app. Adam Comella Microsoft Corp. Closes https://github.com/facebook/react-native/pull/9594 Differential Revision: D3810166 Pulled By: foghina fbshipit-source-id: 229c9bfc3ef10670a1090311ea9d095cb2c1121a
Building React Native for Android
See the docs on the website.
Running tests
When you submit a pull request CircleCI will automatically run all tests. To run tests locally, see Testing.