status-im
/
react-native
mirror of https://github.com/status-im/react-native.git
2
0
Fork 0
Code Issues Projects Releases Wiki Activity
react-native/Libraries
History
MateusAndrade cc13a7367b Improving Modal `visible` prop check to handle undefined and null (#22072) 
Summary:
Changing the the this.props.visible if to be ` if (!!this.props.visible === false)` . So passing undefined, or other values wont set the modal to be visible. Granting that anything that is not true, will set the modal to null on the render.

I make this this PR, because on the company that im working, we used a lot of RN. At the moment, we arent using anything like flow or TS. But to grant that the modals will only show if they are set visible to true i have changed the if made.

_Pull requests that expand test coverage are more likely to get reviewed. Add a test case whenever possible!_
Pull Request resolved: https://github.com/facebook/react-native/pull/22072

Differential Revision: D12918086

Pulled By: TheSavior

fbshipit-source-id: 8f9c63ac6fd56d83949bb8428ad7c5b7bf805c49
 		2018-11-03 18:44:53 -07:00
..
ART Flow strictifying AdsManagerAudienceImages.js 2018-11-01 09:52:41 -07:00
ActionSheetIOS Update copyright headers to yearless format 2018-09-11 15:33:07 -07:00
Alert Update copyright headers to yearless format 2018-09-11 15:33:07 -07:00
Animated Improved Types 2018-11-01 16:22:31 -07:00
AppState Update copyright headers to yearless format 2018-09-11 15:33:07 -07:00
BatchedBridge Change new Date() to Date.now() to save on date allocations 2018-09-21 11:11:33 -07:00
Blob Update copyright headers to yearless format 2018-09-11 15:33:07 -07:00
BugReporting Remove explicit requires of Map and Set 2018-10-19 10:57:24 -07:00
CameraRoll Additional Flow changes to files that use this component 2018-10-18 12:28:28 -07:00
Color Update copyright headers to yearless format 2018-09-11 15:33:07 -07:00
Components Remove createReactClass from ProgressBarAndroidExample (#21874) 2018-11-02 12:14:29 -07:00
Core Modularize InitializeCore 2018-10-28 15:45:14 -07:00
DeprecatedPropTypes Move createStrictShapeTypeChecker to deprecated 2018-10-12 15:17:02 -07:00
EventEmitter Update copyright headers to yearless format 2018-09-11 15:33:07 -07:00
Experimental Remove createReactClass from SwipeableRow (#21876) 2018-11-02 07:27:46 -07:00
Geolocation Update copyright headers to yearless format 2018-09-11 15:33:07 -07:00
Image Fix the comment for getSize in Image.android.js (#22092) 2018-11-03 18:37:25 -07:00
Inspector Refactor 2018-10-22 17:11:50 -07:00
Interaction Remove explicit requires of Map and Set 2018-10-19 10:57:24 -07:00
JSInspector Remove explicit requires of Map and Set 2018-10-19 10:57:24 -07:00
LayoutAnimation RN: Remove Prop Types from `LayoutAnimation` 2018-09-28 01:07:45 -07:00
Linking Normalize scheme for URL on Android (#21561) 2018-10-09 23:32:24 -07:00
LinkingIOS Update RCTLinkingManager.h to explicitly state the 'nullability' of parameters (#20798) 2018-09-21 06:18:39 -07:00
Lists Modified declarations from vars to const (#22070) 2018-11-01 17:13:17 -07:00
Modal Improving Modal `visible` prop check to handle undefined and null (#22072) 2018-11-03 18:44:53 -07:00
NativeAnimation fix broken animation tests 2018-09-28 09:17:17 -07:00
Network Remove explicit requires of Map and Set 2018-10-19 10:57:24 -07:00
Performance Update copyright headers to yearless format 2018-09-11 15:33:07 -07:00
PermissionsAndroid Update copyright headers to yearless format 2018-09-11 15:33:07 -07:00
PushNotificationIOS Update copyright headers to yearless format 2018-09-11 15:33:07 -07:00
RCTTest RN: Missing Copyright Headers 2018-10-31 01:37:26 -07:00
ReactNative Fix linting issues (#22062) 2018-11-01 14:29:16 -07:00
Renderer React sync for revisions 4773fdf...bf9fadf 2018-11-02 18:35:04 -07:00
Sample RN: Missing Copyright Headers 2018-10-31 01:37:26 -07:00
Settings Update copyright headers to yearless format 2018-09-11 15:33:07 -07:00
Share Update copyright headers to yearless format 2018-09-11 15:33:07 -07:00
Storage Update copyright headers to yearless format 2018-09-11 15:33:07 -07:00
StyleSheet Deploy Flow v0.85 to xplat/js 2018-11-02 00:28:28 -07:00
SurfaceBackedComponent Update copyright headers to yearless format 2018-09-11 15:33:07 -07:00
SurfaceHostingComponent Update copyright headers to yearless format 2018-09-11 15:33:07 -07:00
Text Deploy Flow v0.85 to xplat/js 2018-11-02 00:28:28 -07:00
Types Fix internal flow problems 2018-09-27 14:18:31 -07:00
Utilities Fix linting issues (#22062) 2018-11-01 14:29:16 -07:00
Vibration Add deprecation warnings for a few IOS components 2018-10-22 23:17:13 -07:00
WebSocket Fix duplicate function declaration in WebSockets (#22098) 2018-11-03 18:41:24 -07:00
Wrapper Update copyright headers to yearless format 2018-09-11 15:33:07 -07:00
YellowBox Fix View/Text displayName (#21950) 2018-10-29 12:42:10 -07:00
fishhook Merge fishhook.xcodeproj in RCTWebSocket 2017-08-09 07:48:09 -07:00
polyfills Fix linting issues (#22062) 2018-11-01 14:29:16 -07:00
react-native Add back removal notice of BackAndroid 2018-10-22 11:46:03 -07:00
vendor RN: Missing Copyright Headers 2018-10-31 01:37:26 -07:00
.npmignore npmignore: ignore tests and fixtures 2018-02-27 08:42:14 -08:00
Promise.js Update copyright headers to yearless format 2018-09-11 15:33:07 -07:00
UTFSequence.js Update copyright headers to yearless format 2018-09-11 15:33:07 -07:00
promiseRejectionIsError.js Update copyright headers to yearless format 2018-09-11 15:33:07 -07:00