mirror of
https://github.com/status-im/react-native.git
synced 2025-01-16 04:24:15 +00:00
c858420b2d
Summary: This diff attempts to fix a number of iOS native animation bugs related to improper node invalidation and a race with view creation. The major issues were presented in #9120 as problems 3 and 3b, but I'll recap here: The invalidation model we use is overly complicated and incomplete. The proper combination of `_needsUpdate` and `_hasUpdated` will result in nodes values being recomputed. However, we do not invalidate nodes in all the places we should, e.g. if we create a new view and attach it to an existing value node (see example in #9120). This diff chooses to remove the `_hasUpdated` flag, and simply relies on the `_needsUpdate` flag to mark a node as dirty. We mark nodes as dirty when they are: - created - updated - attached to new parents - detached from old parents - attached to a view Calling `updateNodeIfNecessary` will, if necessary, compute all invalidated parent values before recomputing the node value. It will then apply the update, and mark the no Closes https://github.com/facebook/react-native/pull/10663 Differential Revision: D4120301 Pulled By: mkonicek fbshipit-source-id: e247afcb5d8c15999b8328c664b9f7e764d76a75
121 lines
2.4 KiB
Objective-C
121 lines
2.4 KiB
Objective-C
/**
|
|
* Copyright (c) 2015-present, Facebook, Inc.
|
|
* All rights reserved.
|
|
*
|
|
* This source code is licensed under the BSD-style license found in the
|
|
* LICENSE file in the root directory of this source tree. An additional grant
|
|
* of patent rights can be found in the PATENTS file in the same directory.
|
|
*/
|
|
|
|
#import "RCTAnimatedNode.h"
|
|
|
|
#import <React/RCTDefines.h>
|
|
|
|
@implementation RCTAnimatedNode
|
|
{
|
|
NSMutableDictionary<NSNumber *, RCTAnimatedNode *> *_childNodes;
|
|
NSMutableDictionary<NSNumber *, RCTAnimatedNode *> *_parentNodes;
|
|
}
|
|
|
|
- (instancetype)initWithTag:(NSNumber *)tag
|
|
config:(NSDictionary<NSString *, id> *)config
|
|
{
|
|
if ((self = [super init])) {
|
|
_nodeTag = tag;
|
|
_config = [config copy];
|
|
}
|
|
return self;
|
|
}
|
|
|
|
RCT_NOT_IMPLEMENTED(- (instancetype)init)
|
|
|
|
- (NSDictionary<NSNumber *, RCTAnimatedNode *> *)childNodes
|
|
{
|
|
return _childNodes;
|
|
}
|
|
|
|
- (NSDictionary<NSNumber *, RCTAnimatedNode *> *)parentNodes
|
|
{
|
|
return _parentNodes;
|
|
}
|
|
|
|
- (void)addChild:(RCTAnimatedNode *)child
|
|
{
|
|
if (!_childNodes) {
|
|
_childNodes = [NSMutableDictionary new];
|
|
}
|
|
if (child) {
|
|
_childNodes[child.nodeTag] = child;
|
|
[child onAttachedToNode:self];
|
|
}
|
|
}
|
|
|
|
- (void)removeChild:(RCTAnimatedNode *)child
|
|
{
|
|
if (!_childNodes) {
|
|
return;
|
|
}
|
|
if (child) {
|
|
[_childNodes removeObjectForKey:child.nodeTag];
|
|
[child onDetachedFromNode:self];
|
|
}
|
|
}
|
|
|
|
- (void)onAttachedToNode:(RCTAnimatedNode *)parent
|
|
{
|
|
if (!_parentNodes) {
|
|
_parentNodes = [NSMutableDictionary new];
|
|
}
|
|
if (parent) {
|
|
_parentNodes[parent.nodeTag] = parent;
|
|
}
|
|
}
|
|
|
|
- (void)onDetachedFromNode:(RCTAnimatedNode *)parent
|
|
{
|
|
if (!_parentNodes) {
|
|
return;
|
|
}
|
|
if (parent) {
|
|
[_parentNodes removeObjectForKey:parent.nodeTag];
|
|
}
|
|
}
|
|
|
|
- (void)detachNode
|
|
{
|
|
for (RCTAnimatedNode *parent in _parentNodes.allValues) {
|
|
[parent removeChild:self];
|
|
}
|
|
for (RCTAnimatedNode *child in _childNodes.allValues) {
|
|
[self removeChild:child];
|
|
}
|
|
}
|
|
|
|
- (void)setNeedsUpdate
|
|
{
|
|
_needsUpdate = YES;
|
|
for (RCTAnimatedNode *child in _childNodes.allValues) {
|
|
[child setNeedsUpdate];
|
|
}
|
|
}
|
|
|
|
- (void)updateNodeIfNecessary
|
|
{
|
|
if (_needsUpdate) {
|
|
for (RCTAnimatedNode *parent in _parentNodes.allValues) {
|
|
[parent updateNodeIfNecessary];
|
|
}
|
|
[self performUpdate];
|
|
}
|
|
}
|
|
|
|
- (void)performUpdate
|
|
{
|
|
_needsUpdate = NO;
|
|
// To be overidden by subclasses
|
|
// This method is called on a node only if it has been marked for update
|
|
// during the current update loop
|
|
}
|
|
|
|
@end
|