react-native/local-cli
Angly Cat c6610577fd Fix launching iOS simulator regression
Summary:
PR #17284 (accepted in 2ad34075f1) introduced a couple of regressions.

~1. There's the code:~
```
.then((appName) => resolve(selectedSimulator.udid, appName));
/* ... */
.then((udid, appName) => {
```

~~This makes `appName` to be always `undefined` as per `resolve` accepts only 1 argument. This regression causes issues if an app name differs from a scheme name.~

~This PR fixes this by wrapping both values in an array.~

This was fixed in 589eae1432.

2. The code
```
child_process.execFileSync('xcrun', ['simctl', 'boot', selectedSimulator.udid]);
```
makes a simulator *boot*, but the simulator *doesn't launch*. That's a regression, which forces developers to launch simulators by other means (by running a number of elaborate console commands, by running Xcode, or by running a simulator manually).

This PR reverts that part of changes.

Create a blank project with a name that differs from scheme name. Try to `react-native run-ios` in it. See that a simulator is launched and installing succeeds. Without this changes simulator wouldn't launch, and installing step would fail because of app name mismatch.

[CLI][BUGFIX][local-cli/runIOS/runIOS.js] - Fix running on multiple simulators feature regressions
Closes https://github.com/facebook/react-native/pull/18711

Differential Revision: D7535150

Pulled By: hramos

fbshipit-source-id: 5c714231e9977c0c829b6f8c793497cd31cd46b5
2018-04-06 10:12:37 -07:00
..
__mocks__ Update license headers for MIT license 2018-02-16 18:31:53 -08:00
__tests__ @allow-large-files Upgrade xplat/js to Flow v0.66 2018-02-16 20:24:57 -08:00
bundle Adds an experimental hook for custom resolutions 2018-04-05 09:00:04 -07:00
core Update additional license headers 2018-03-08 12:10:14 -08:00
dependencies Remove optional parameter from server and enforce empty list everywhere 2018-03-01 05:33:05 -08:00
eject Update license headers for MIT license 2018-02-16 18:31:53 -08:00
generator Update license headers for MIT license 2018-02-16 18:31:53 -08:00
info Update license headers for MIT license 2018-02-16 18:31:53 -08:00
init Update license headers for MIT license 2018-02-16 18:31:53 -08:00
install Update license headers for MIT license 2018-02-16 18:31:53 -08:00
library Use sync fs.mkdir 2018-02-25 21:49:28 -08:00
link While linking plugin ask for params only once 2018-03-20 14:49:55 -07:00
logAndroid Update license headers for MIT license 2018-02-16 18:31:53 -08:00
logIOS Update license headers for MIT license 2018-02-16 18:31:53 -08:00
runAndroid Update license headers for MIT license 2018-02-16 18:31:53 -08:00
runIOS Fix launching iOS simulator regression 2018-04-06 10:12:37 -07:00
server Adds an experimental hook for custom resolutions 2018-04-05 09:00:04 -07:00
templates Inline and fix proguard rules 2018-04-05 17:34:53 -07:00
upgrade Update license headers for MIT license 2018-02-16 18:31:53 -08:00
util Fix #17610, Add fixtures to metro blacklist 2018-02-16 20:48:15 -08:00
.npmignore npmignore: ignore tests and fixtures 2018-02-27 08:42:14 -08:00
cli.js Update license headers for MIT license 2018-02-16 18:31:53 -08:00
cliEntry.js Update license headers for MIT license 2018-02-16 18:31:53 -08:00
commands.js Update license headers for MIT license 2018-02-16 18:31:53 -08:00
setup_env.bat Update license headers for MIT license 2018-02-16 18:31:53 -08:00
setup_env.sh Update license headers for MIT license 2018-02-16 18:31:53 -08:00
wrong-react-native.js Update license headers for MIT license 2018-02-16 18:31:53 -08:00