mirror of
https://github.com/status-im/react-native.git
synced 2025-02-23 22:58:19 +00:00
bea80b2276
Summary: For some time we have had a nit trick inside `EventEmitter`: When event emitter is disabled, we switch to store `EventTarget` as a weak pointer instead of complete deleting it. Given some unpredictability of JS GC, it gave us some time to restore the pointer in case if we increment the counter right after decrementing this. Apparently, we found that it doesn't always work (obviously, sigh...), so we implement the `enableCounter_` and left this feature as it is assuming that it can nice optimization that illuminates some unnecessary constraints. But, apparently, it's actually harmful, assuming that `jsi::WeakObject` (that thing that we use to refer to actual JS target) actually has "unsafe unretained" (not "weak") semantic. So, we have to remove this. This change will be particularly important for coming diffs in the stack. Reviewed By: mdvacca Differential Revision: D13324480 fbshipit-source-id: 4c4da2984dc6a36b94b564bc9eee144142b430b0