mirror of
https://github.com/status-im/react-native.git
synced 2025-01-29 18:54:58 +00:00
4203c9c837
Summary: The problem with `bundleOpts` is that it discards Flow typing, so it prevents reinforcing the integration of `Bundler` into `Server`. This changeset removes the `bundleOpts` to solve that issues. Instead, it makes the options explicit so that there is less uncertaintly. I love making options explicit, because they force callsites to take a consicious decision about what is really needed, making them more robust. They also expose oddities that probably needs refatoring, for example having a `resolutionRequest` in the bundle options does not seem correct, it should be an implementation details. Likewise, `onProgress` should probably be exposed differently, as it does not affect the content of the bundle itself. Reviewed By: davidaurelio Differential Revision: D4697729 fbshipit-source-id: d543870ba024e7588c10b101fa51429c77cc5ddc
83 lines
2.3 KiB
JavaScript
83 lines
2.3 KiB
JavaScript
/**
|
|
* Copyright (c) 2015-present, Facebook, Inc.
|
|
* All rights reserved.
|
|
*
|
|
* This source code is licensed under the BSD-style license found in the
|
|
* LICENSE file in the root directory of this source tree. An additional grant
|
|
* of patent rights can be found in the PATENTS file in the same directory.
|
|
*
|
|
* @flow
|
|
*/
|
|
|
|
'use strict';
|
|
|
|
const Server = require('../../../packager/src/Server');
|
|
|
|
const meta = require('./meta');
|
|
const relativizeSourceMap = require('../../../packager/src//lib/relativizeSourceMap');
|
|
const writeFile = require('./writeFile');
|
|
|
|
import type Bundle from '../../../packager/src//Bundler/Bundle';
|
|
import type {OutputOptions, RequestOptions} from '../types.flow';
|
|
|
|
function buildBundle(packagerClient: Server, requestOptions: RequestOptions) {
|
|
return packagerClient.buildBundle({
|
|
...Server.DEFAULT_BUNDLE_OPTIONS,
|
|
...requestOptions,
|
|
isolateModuleIDs: true,
|
|
});
|
|
}
|
|
|
|
function createCodeWithMap(bundle: Bundle, dev: boolean, sourceMapSourcesRoot?: string): * {
|
|
const map = bundle.getSourceMap({dev});
|
|
const sourceMap = relativizeSourceMap(
|
|
typeof map === 'string' ? JSON.parse(map) : map,
|
|
sourceMapSourcesRoot);
|
|
return {
|
|
code: bundle.getSource({dev}),
|
|
map: JSON.stringify(sourceMap),
|
|
};
|
|
}
|
|
|
|
function saveBundleAndMap(
|
|
bundle: Bundle,
|
|
options: OutputOptions,
|
|
log: (x: string) => {},
|
|
): Promise<> {
|
|
const {
|
|
bundleOutput,
|
|
bundleEncoding: encoding,
|
|
dev,
|
|
sourcemapOutput,
|
|
sourcemapSourcesRoot
|
|
} = options;
|
|
|
|
log('start');
|
|
const codeWithMap = createCodeWithMap(bundle, !!dev, sourcemapSourcesRoot);
|
|
log('finish');
|
|
|
|
log('Writing bundle output to:', bundleOutput);
|
|
|
|
const {code} = codeWithMap;
|
|
const writeBundle = writeFile(bundleOutput, code, encoding);
|
|
const writeMetadata = writeFile(
|
|
bundleOutput + '.meta',
|
|
meta(code, encoding),
|
|
'binary');
|
|
Promise.all([writeBundle, writeMetadata])
|
|
.then(() => log('Done writing bundle output'));
|
|
|
|
if (sourcemapOutput) {
|
|
log('Writing sourcemap output to:', sourcemapOutput);
|
|
const writeMap = writeFile(sourcemapOutput, codeWithMap.map, null);
|
|
writeMap.then(() => log('Done writing sourcemap output'));
|
|
return Promise.all([writeBundle, writeMetadata, writeMap]);
|
|
} else {
|
|
return writeBundle;
|
|
}
|
|
}
|
|
|
|
exports.build = buildBundle;
|
|
exports.save = saveBundleAndMap;
|
|
exports.formatName = 'bundle';
|