status-im
/
react-native
mirror of https://github.com/status-im/react-native.git
2
0
Fork 0
Code Issues Projects Releases Wiki Activity
react-native/Libraries/WebSocket
History
Eric Rozell 4b6e9d3dfd Revert "Remove Platform check from WebSocket module" 
Summary:
This reverts commit b9be28915c.

Thank you for sending the PR! We appreciate you spending the time to work on these changes.
Help us understand your motivation by explaining why you decided to make this change.

<!--
  Required: Write your motivation here.
  If this PR fixes an issue, type "Fixes #issueNumber" to automatically close the issue when the PR is merged.
-->

Fix #18696

<!--
  Required: Write your test plan here. If you changed any code, please provide us with
  clear instructions on how you verified your changes work. Bonus points for screenshots and videos!
-->

Run Jest tests.
Run WebSocket example from RNTester on Android.

<!--
  Does this PR require a documentation change?
  Create a PR at https://github.com/facebook/react-native-website and add a link to it here.
-->

<!--
  Required.
  Help reviewers and the release process by writing your own release notes. See below for an example.
-->

[CATEGORY] [TYPE] [LOCATION] - Message

<!--
  **INTERNAL and MINOR tagged notes will not be included in the next version's final release notes.**

    CATEGORY
  [----------]      TYPE
  [ CLI      ] [-------------]    LOCATION
  [ DOCS     ] [ BREAKING    ] [-------------]
  [ GENERAL  ] [ BUGFIX      ] [ {Component} ]
  [ INTERNAL ] [ ENHANCEMENT ] [ {Filename}  ]
  [ IOS      ] [ FEATURE     ] [ {Directory} ]   |-----------|
  [ ANDROID  ] [ MINOR       ] [ {Framework} ] - | {Message} |
  [----------] [-------------] [-------------]   |-----------|

 EXAMPLES:

 [IOS] [BREAKING] [FlatList] - Change a thing that breaks other things
 [ANDROID] [BUGFIX] [TextInput] - Did a thing to TextInput
 [CLI] [FEATURE] [local-cli/info/info.js] - CLI easier to do things with
 [DOCS] [BUGFIX] [GettingStarted.md] - Accidentally a thing/word
 [GENERAL] [ENHANCEMENT] [Yoga] - Added new yoga thing/position
 [INTERNAL] [FEATURE] [./scripts] - Added thing to script that nobody will see
-->
[ANDROID][BUGFIX][WebSocketModule] - revert change that regresses WebSocketModule
Closes https://github.com/facebook/react-native/pull/18733

Differential Revision: D7548850

Pulled By: hramos

fbshipit-source-id: b8c79810c1cd6e5a30ec4118bd5ff8ad719f04b9
 		2018-04-08 18:15:53 -07:00
..
RCTWebSocket.xcodeproj adds --port option to `react-native run-ios` as well as patches port … 2018-01-04 20:11:10 -08:00
__mocks__
…
__tests__ Update license headers for MIT license 2018-02-16 18:31:53 -08:00
RCTReconnectingWebSocket.h Update license headers for MIT license 2018-02-16 18:31:53 -08:00
RCTReconnectingWebSocket.m Update license headers for MIT license 2018-02-16 18:31:53 -08:00
RCTSRWebSocket.h
…
RCTSRWebSocket.m Merge RCTPackagerClient into RCTPackagerConnection 2017-05-05 08:49:28 -07:00
RCTWebSocketExecutor.h Update license headers for MIT license 2018-02-16 18:31:53 -08:00
RCTWebSocketExecutor.m Increase timeouts to 15, 10 2018-03-28 04:45:26 -07:00
RCTWebSocketModule.h Update license headers for MIT license 2018-02-16 18:31:53 -08:00
RCTWebSocketModule.m use correct delegate queue in RCTRSWebSocket 2018-03-24 23:16:20 -07:00
WebSocket.js Revert "Remove Platform check from WebSocket module" 2018-04-08 18:15:53 -07:00
WebSocketEvent.js Update license headers for MIT license 2018-02-16 18:31:53 -08:00
WebSocketInterceptor.js Update license headers for MIT license 2018-02-16 18:31:53 -08:00