mirror of
https://github.com/status-im/react-native.git
synced 2025-02-13 18:06:37 +00:00
b850af7a39
Summary: Motivation: fix #11884 issue I will try in short to explain what was wrong. Let's look to transformation's matrix for **skewY** for example. | cos(a) | sin(a) | 0 | 0 | |:------:|:------:|:------:|:-----:| | 0 | 1 | 0 | 0 | | 0 | 0 | 1 | 0 | | tx | ty | tz | 1 || Yes, this visually produce skewing transform but it slightly incorrect. This way affects horizontal scale as well. See [this](https://github.com/facebook/react-native/issues/11884) | 1 | tan(a) | 0 | 0 | |:------:|:------:|:------:|:-----:| | 0 | 1 | 0 | 0 | | 0 | 0 | 1 | 0 | | tx | ty | tz | 1 || According to [www.w3.org/css-transforms](https://www.w3.org/TR/css-transforms-1/#SkewDefined) Only one differance React Native use **row major matrix style**, so we change ```m[0][1]``` instead ```m[1][0]```. sahrens vjeux Closes https://github.com/facebook/react-native/pull/11992 Differential Revision: D4436470 Pulled By: vjeux fbshipit-source-id: 1b433f04650bae7e06b5a93f521e49f11c70cce3