mirror of https://github.com/status-im/react-native.git synced 2025-02-10 16:36:25 +00:00

History

James Reggio dc01eff72d Fix crash with non-zero blurRadius less than 1

Summary:
There's a crash-inducing bug with `Image.blurRadius` on Android.

`blurRadius` is specified in JavaScript as a `float`, but it's cast to `int` before being passed to the `IterativeBoxBlurPostProcessor`. However, in `IterativeBoxBlurPostProcessor`, there is an argument precondition requiring the integer `blurRadius` to be non-zero.

Because the `== 0` condition is evaluated on the `float`, it's possible for a `blurRadius` in the range of `(0, 1)` (non-inclusive) to pass the conditional, and then be truncated to `0` and passed as an argument to `IterativeBoxBlurPostProcessor`, which will fail its precondition and crash the app.

This change works in our app, which was previously crashing.

[ANDROID] [BUGFIX] [Image] Fixed crash when specifying an Image.blurRadius between (0, 1)
Closes https://github.com/facebook/react-native/pull/16845

Differential Revision: D6387416

Pulled By: shergin

fbshipit-source-id: d5191aa97e949ffd41e6d68c96b3c7bcbc82a52e

2017-11-21 12:30:49 -08:00

libs

Add include_defs("//ReactAndroid/DEFS") to all BUCK files in ReactAndroid

2017-09-29 16:16:06 -07:00

src

Fix crash with non-zero blurRadius less than 1

2017-11-21 12:30:49 -08:00

.npmignore

…

build.gradle

Update OSS Fresco dependency

2017-07-12 07:54:09 -07:00