react-native/Examples/Movies
Aymen Mouelhi c4e73ddd92 Fix Issue with network errors
Summary:
When running the Movies Example, the application displays an error message: "Cannot read property 'total' of undefined".
<img width="374" alt="capture d ecran 2017-03-01 a 21 26 50" src="https://cloud.githubusercontent.com/assets/3247607/23479864/2871c52a-fec6-11e6-9266-8a5fe44adfe4.png">

This is due to the fact that the API call raised an error, and the catch block is followed by a then block, which means that the code in the second then bloc will be executed.

The fix is to move the catch at the last position, to prevent any further execution in case of network error.
Closes https://github.com/facebook/react-native/pull/12641

Differential Revision: D4657739

Pulled By: ericvicenti

fbshipit-source-id: bdc58d2b89a7d2a53de716773e7bc8a735fa2e45
2017-03-05 19:02:54 -08:00
..
Movies Changed JS location of examples to source from RCTBundleURLProvider instead. 2016-07-15 10:13:29 -07:00
Movies.xcodeproj Redo exported headers and include paths for opensource 2016-12-07 15:28:29 -08:00
__tests__ Update Jest APIs on fbsource 2016-04-27 19:16:32 -07:00
android/app Apply auto-formatter for BUCK files in fbandroid. 2017-02-27 14:04:56 -08:00
MovieCell.js Add @providesModule annotations 2017-02-27 14:04:56 -08:00
MovieScreen.js Add @providesModule annotations 2017-02-27 14:04:56 -08:00
MoviesApp.android.js Kill require('image!...') 2016-11-22 21:13:52 -08:00
MoviesApp.ios.js Convert from React.createClass to ES6 classes 2016-07-26 01:13:31 -07:00
README.md Consolidate Running on Device (Android|iOS) Guides into one 2016-11-06 21:13:32 -08:00
SearchBar.android.js Kill require('image!...') 2016-11-22 21:13:52 -08:00
SearchBar.ios.js Convert from React.createClass to ES6 classes 2016-07-26 01:13:31 -07:00
SearchScreen.js Fix Issue with network errors 2017-03-05 19:02:54 -08:00
getImageSource.js Add @providesModule annotations 2017-02-27 14:04:56 -08:00
getStyleFromScore.js Add @providesModule annotations 2017-02-27 14:04:56 -08:00
getTextFromScore.js Add @providesModule annotations 2017-02-27 14:04:56 -08:00

README.md

Movies app

The Movies app is a demonstration of basic concepts, such as fetching data, rendering a list of data including images, and navigating between different screens.

Running this app

Before running the app, make sure you ran:

git clone https://github.com/facebook/react-native.git
cd react-native
npm install

Running on iOS

Mac OS and Xcode are required.

  • Open Examples/Movies/Movies.xcodeproj in Xcode
  • Hit the Run button

See Running on device if you want to use a physical device.

Running on Android

You'll need to have all the prerequisites (SDK, NDK) for Building React Native installed.

Start an Android emulator (Genymotion is recommended).

cd react-native
./gradlew :Examples:Movies:android:app:installDebug
./packager/packager.sh

Note: Building for the first time can take a while.

Open the Movies app in your emulator.

See Running on Device in case you want to use a physical device.

Running with Buck

Follow the same setup as running with gradle.

Install Buck from here.

Run the following commands from the react-native folder:

./gradlew :ReactAndroid:packageReactNdkLibsForBuck
buck fetch movies
buck install -r movies
./packager/packager.sh

Note: The native libs are still built using gradle. Full build with buck is coming soon(tm).

Built from source

Building the app on both iOS and Android means building the React Native framework from source. This way you're running the latest native and JS code the way you see it in your clone of the github repo.

This is different from apps created using react-native init which have a dependency on a specific version of React Native JS and native code, declared in a package.json file (and build.gradle for Android apps).