Valentin Shergin eabf29e320 Fabric: Getting rid of many auto &&
Summary:
@public
After reading about move-semantic and rvalue refs I realized that we (I) definitely overuse  `auto &&` (aka universal reference) construction. Even if this is harmless, does not look good and idiomatic.
Whenever I used that from a semantical point of view I always meant  "I need an alias for this" which is actually "read-only reference" which is `const auto &`.
This is also fit good to our policy where "everything is const (immutable) by default".
Hence I change that to how it should be.

Reviewed By: fkgozali

Differential Revision: D8475637

fbshipit-source-id: 0a691ededa0e798db8ffa053bff0f400913ab7b8
2018-06-22 07:32:49 -07:00

60 lines
1.6 KiB
C++

/**
* Copyright (c) 2015-present, Facebook, Inc.
*
* This source code is licensed under the MIT license found in the
* LICENSE file in the root directory of this source tree.
*/
#include "EventEmitter.h"
#include <folly/dynamic.h>
namespace facebook {
namespace react {
EventEmitter::EventEmitter(const InstanceHandle &instanceHandle, const Tag &tag, const SharedEventDispatcher &eventDispatcher):
instanceHandle_(instanceHandle),
tag_(tag),
eventDispatcher_(eventDispatcher) {
if (eventDispatcher) {
eventTarget_ = createEventTarget();
}
}
EventEmitter::~EventEmitter() {
auto &&eventDispatcher = eventDispatcher_.lock();
if (eventDispatcher && eventTarget_) {
eventDispatcher->releaseEventTarget(eventTarget_);
}
}
void EventEmitter::dispatchEvent(
const std::string &type,
const folly::dynamic &payload,
const EventPriority &priority
) const {
const auto &eventDispatcher = eventDispatcher_.lock();
if (!eventDispatcher) {
return;
}
assert(eventTarget_ && "Attempted to dispatch an event without an eventTarget.");
// Mixing `target` into `payload`.
assert(payload.isObject());
folly::dynamic extendedPayload = folly::dynamic::object("target", tag_);
extendedPayload.merge_patch(payload);
// TODO(T29610783): Reconsider using dynamic dispatch here.
eventDispatcher->dispatchEvent(eventTarget_, type, extendedPayload, priority);
}
EventTarget EventEmitter::createEventTarget() const {
const auto &eventDispatcher = eventDispatcher_.lock();
assert(eventDispatcher);
return eventDispatcher->createEventTarget(instanceHandle_);
}
} // namespace react
} // namespace facebook