status-im
/
react-native
mirror of https://github.com/status-im/react-native.git
2
0
Fork 0
Code Issues Projects Releases Wiki Activity
react-native/Libraries
History
m30do ae60ae4074 fix ItemSeparatorComponent position in horizontal and inverted mode 
Summary:
<!--
Thank you for sending the PR! We appreciate you spending the time to work on these changes.

Help us understand your motivation by explaining why you decided to make this change.

You can learn more about contributing to React Native here: http://facebook.github.io/react-native/docs/contributing.html

Happy contributing!

-->

There's a positioning bug in `VirtualizedList` when `ItemSeparatorComponent` is defined for a list in horizontal or inverted mode. And also we face this bug in `FlatList`, because it is using `VirtualizedList` to render lists.
This commit will fix the [#15777](https://github.com/facebook/react-native/issues/15777).

Before fix:
```
<FlatList
  ...
  horizontal={true}
  inverted={true}
  ...
/>
```

![image](https://user-images.githubusercontent.com/15084663/30205251-95f14c70-949d-11e7-85e9-7a3304a52818.png)

```
<FlatList
  ...
  horizontal={true}
  inverted={false}
  ...
/>
```
![image](https://user-images.githubusercontent.com/15084663/30205411-f01d27b4-949d-11e7-991e-00aeae0c01e0.png)

I ran this code with all possible values of `horizontal` and `inverted` props in `FlatList` and `VirtualizedList` and the results of each run was as below:
After fix bug:

```
<FlatList
  ...
  horizontal={true}
  inverted={false}
  ...
/>
```
![image](https://user-images.githubusercontent.com/15084663/30205498-323bcf60-949e-11e7-8ba0-465614ea5cf2.png)

```
<FlatList
  ...
  horizontal={true}
  inverted={true}
  ...
/>
```
![image](https://user-images.githubusercontent.com/15084663/30205543-5274f612-949e-11e7-9660-bbdf8194cd27.png)
Closes https://github.com/facebook/react-native/pull/15865

Differential Revision: D5797266

Pulled By: hramos

fbshipit-source-id: 7d44fa797dbd9e83eb2bdd7833e9dd9707d9d822
 		2017-09-08 15:06:50 -07:00
..
ART Standardize project indentation settings on 2 spaces 2017-07-31 05:20:03 -07:00
ActionSheetIOS Standardize project indentation settings on 2 spaces 2017-07-31 05:20:03 -07:00
Alert Alert - allow for hiding alert title on iOS 2017-08-30 17:16:17 -07:00
Animated Fix React Native open source 2017-08-29 15:01:05 -07:00
AppState Avoid race condition for AppState.currentState 2017-08-18 13:14:59 -07:00
BatchedBridge Reverting changes to MessageQueue 2017-09-07 14:30:59 -07:00
Blob @allow-large-files Flow v0.54.0 2017-09-06 03:33:43 -07:00
BugReporting Patch up for future React Sync 2017-02-08 14:50:43 -08:00
CameraRoll Example of getPhotos Method 2017-09-01 11:48:54 -07:00
Components color filters - use TouchableBounce and make it configurable 2017-09-06 16:38:37 -07:00
Core @allow-large-files Flow v0.54.0 2017-09-06 03:33:43 -07:00
EventEmitter Turn on Flow for EventEmitter 2017-08-30 11:52:28 -07:00
Experimental @allow-large-files Flow v0.54.0 2017-09-06 03:33:43 -07:00
Geolocation @allow-large-files Flow v0.54.0 2017-09-06 03:33:43 -07:00
Image consistent use of URL for resolving asset source 2017-09-08 10:47:22 -07:00
Inspector @allow-large-files Flow v0.54.0 2017-09-06 03:33:43 -07:00
Interaction Reverting changes to MessageQueue 2017-09-07 14:30:59 -07:00
JSInspector Add Network agent 2016-11-02 12:29:15 -07:00
LayoutAnimation @allow-large-files Flow v0.54.0 2017-09-06 03:33:43 -07:00
Linking fix flow warning and typo 2017-09-08 14:46:14 -07:00
LinkingIOS Standardize project indentation settings on 2 spaces 2017-07-31 05:20:03 -07:00
Lists fix ItemSeparatorComponent position in horizontal and inverted mode 2017-09-08 15:06:50 -07:00
Modal Upgrade fbsource/xplat/js to Flow v0.53.0 2017-08-17 18:45:01 -07:00
NativeAnimation Standardize project indentation settings on 2 spaces 2017-07-31 05:20:03 -07:00
Network @allow-large-files Flow v0.54.0 2017-09-06 03:33:43 -07:00
Performance Gate more code with if (__DEV__) { } 2017-08-14 07:19:00 -07:00
PermissionsAndroid Update documentation for PermissionsAndroid 2017-08-16 15:01:51 -07:00
PushNotificationIOS Fix flowtype errors for PushNotificationIOS 2017-08-14 12:03:18 -07:00
RCTTest Increase RCTTestRunner timeouts 2017-08-25 10:00:39 -07:00
ReactNative @allow-large-files Flow v0.54.0 2017-09-06 03:33:43 -07:00
Renderer Fix React Native open source 2017-08-29 15:01:05 -07:00
Sample Standardize project indentation settings on 2 spaces 2017-07-31 05:20:03 -07:00
Settings Fix infinite recursion in RCTSettingsManager init 2017-08-09 09:39:40 -07:00
Share Flowify Process Color 2017-04-26 11:31:56 -07:00
Storage correctly order ASyncStorage 2017-02-21 15:18:40 -08:00
StyleSheet Fix stylesheet registery 2017-08-23 08:54:39 -07:00
Text @allow-large-files Flow v0.54.0 2017-09-06 03:33:43 -07:00
Utilities @allow-large-files Flow v0.54.0 2017-09-06 03:33:43 -07:00
Vibration fix and enrich Vibration docs 2017-08-23 20:45:45 -07:00
WebSocket @allow-large-files Flow v0.54.0 2017-09-06 03:33:43 -07:00
fishhook Merge fishhook.xcodeproj in RCTWebSocket 2017-08-09 07:48:09 -07:00
polyfills Use proper script way to clone Emoji files from www 2017-08-21 16:29:39 -07:00
react-native Add Android React Native Checkbox 2017-08-25 10:30:54 -07:00
vendor @allow-large-files Flow v0.54.0 2017-09-06 03:33:43 -07:00
.eslintrc Disallow trailing commas in react-native-github 2017-08-17 16:20:04 -07:00
Promise.js @allow-large-files Flow v0.54.0 2017-09-06 03:33:43 -07:00
promiseRejectionIsError.js @allow-large-files Flow v0.54.0 2017-09-06 03:33:43 -07:00