mirror of
https://github.com/status-im/react-native.git
synced 2025-01-29 02:35:41 +00:00
b20b20656a
Summary:
When testing `react-native-git-upgrade` locally I noticed a warning:
A more recent version of "react-native-git-upgrade" has been found:
Current: 0.1.0
Latest: 0.0.1
See https://www.npmjs.com/package/react-native-git-upgrade
This won't happen to a lot of people but better fix the warning. Also, if the check for updates fails, don't crash - the check for updates is not critical to the tool working.
Also, slightly updated one error message.
**Test plan (required)**
Installed `react-native-git-upgrade` locally, ran it inside an app folder (RN 0.29).
Didn't see the wrong "more recent version" warning anymore.
Tried making `checkForUpdates` fail by adding some dummy code: `semver.foo()`. Saw a warning but the process continued:
git-upgrade WARN Check for latest version failed semver.foo is not a function
Saw a more descriptive error message:
git-upgrade ERR! Error: react-native version in "package.json" (0.29.0) doesn't match the installed version in "node_mod
Closes https://github.com/facebook/react-native/pull/11188
Differential Revision: D4244002
Pulled By: bestander
fbshipit-source-id: 772044750a933663cb516201d09e2873462cca4a
73 lines
2.3 KiB
JavaScript
73 lines
2.3 KiB
JavaScript
/**
|
|
* Copyright (c) 2015-present, Facebook, Inc.
|
|
* All rights reserved.
|
|
*
|
|
* This source code is licensed under the BSD-style license found in the
|
|
* LICENSE file in the root directory of this source tree. An additional grant
|
|
* of patent rights can be found in the PATENTS file in the same directory.
|
|
*/
|
|
'use strict';
|
|
|
|
const {execSync} = require('child_process');
|
|
const semver = require('semver');
|
|
|
|
function checkDeclaredVersion(declaredVersion) {
|
|
if (!declaredVersion) {
|
|
throw new Error(
|
|
'Your "package.json" file doesn\'t seem to have "react-native" as a dependency.'
|
|
);
|
|
}
|
|
}
|
|
|
|
function checkMatchingVersions(currentVersion, declaredVersion) {
|
|
if (!semver.satisfies(currentVersion, declaredVersion)) {
|
|
throw new Error(
|
|
'react-native version in "package.json" (' + declaredVersion + ') doesn\'t match ' +
|
|
'the installed version in "node_modules" (' + currentVersion + ').\n' +
|
|
'Try running "npm install" to fix this.'
|
|
);
|
|
}
|
|
}
|
|
|
|
function checkReactPeerDependency(currentVersion, declaredReactVersion) {
|
|
if (semver.lt(currentVersion, '0.21.0') && !declaredReactVersion) {
|
|
throw new Error(
|
|
'Your "package.json" file doesn\'t seem to have "react" as a dependency.\n' +
|
|
'"react" was changed from a dependency to a peer dependency in react-native v0.21.0.\n' +
|
|
'Therefore, it\'s necessary to include "react" in your project\'s dependencies.\n' +
|
|
'Please run "npm install --save react", then re-run ' +
|
|
'"react-native upgrade".'
|
|
);
|
|
}
|
|
}
|
|
|
|
function checkGitAvailable() {
|
|
try {
|
|
execSync('git --version');
|
|
} catch (error) {
|
|
throw new Error(
|
|
'"react-native-git-upgrade" requires "git" to be available in path. ' +
|
|
'Please install Git (https://git-scm.com)"'
|
|
);
|
|
}
|
|
}
|
|
|
|
function checkNewVersion(newVersion, requiredVersion) {
|
|
if (!semver.valid(newVersion) && requiredVersion) {
|
|
throw new Error(
|
|
'The specified version of React Native ' + requiredVersion + ' doesn\'t exist.\n' +
|
|
'Re-run the react-native-git-upgrade command with an existing version,\n' +
|
|
'for example: "react-native-git-upgrade 0.38.0",\n' +
|
|
'or without arguments to upgrade to the latest: "react-native-git-upgrade".'
|
|
);
|
|
}
|
|
}
|
|
|
|
module.exports = {
|
|
checkDeclaredVersion,
|
|
checkMatchingVersions,
|
|
checkReactPeerDependency,
|
|
checkGitAvailable,
|
|
checkNewVersion,
|
|
};
|