react-native/ReactCommon
Pritesh Nandgaonkar 3770165f72 Fix parent height calculation in case of baseline alignment
Summary:
Prior to this diff, if parents height was not set then the height of parent was deduced as max of childrens height(considering  line ht, padding, margin etc. ), but it didn't consider the baseline scenario where the previous logic will fail as then the parents height will be determined by the space taken by children above and below the reference baseline. I added a test case for the same.

Look at the diff D9088051 which shows the screenshot of the bug.
It is solved to https://pxl.cl/gvVk

Reviewed By: dsyang

Differential Revision: D9219678

fbshipit-source-id: f4a0b9f1452c33e78bd8c6cf39f6fcf538a04074
2018-08-16 16:52:42 -07:00
..
cxxreact Add REGISTER_JS_SEGMENT perf markers 2018-08-10 09:37:42 -07:00
fabric Implement the update of props in the MountingManager layer 2018-08-16 16:52:42 -07:00
jschelpers Bump Android NDK to r17b (#20357) 2018-07-30 14:02:11 -07:00
jsinspector Bump Android NDK to r17b (#20357) 2018-07-30 14:02:11 -07:00
microprofiler Migrate Android sources to MIT license header 2018-05-31 15:37:30 -07:00
privatedata Bump Android NDK to r17b (#20357) 2018-07-30 14:02:11 -07:00
yoga Fix parent height calculation in case of baseline alignment 2018-08-16 16:52:42 -07:00