mirror of https://github.com/status-im/react-native.git synced 2025-01-10 01:25:39 +00:00

History

Wes Johnson a64674375e Alert - allow for hiding alert title on iOS

Summary:
Wanted a "message-only" alert on iOS that doesn't lead to the message being large & bolded via the title field (current state).

Before:

![screen shot 2017-08-28 at 9 22 04 pm](https://user-images.githubusercontent.com/1047502/29801514-fc3629d2-8c3d-11e7-86d5-f0a866301814.png)

After:

![screen shot 2017-08-28 at 9 26 56 pm](https://user-images.githubusercontent.com/1047502/29801521-071aa1ca-8c3e-11e7-9bd0-0a4682d81979.png)

It also aligns iOS with Android's current behaviour.

The above screenhots were generated from the `RNTester` example added herein.

Allowed for passing an empty string through to `UIAlertController.alertControllerWithTitle` so that the message could be rendered in its expected place on iOS (not as the title).

* Ran RNTester & compared example alerts before & after (below default with titles, for example)
* Ran end-to-end manual test suite (it's the only one I could get through without unrelated failures)

Before

![screen shot 2017-08-28 at 9 21 53 pm](https://user-images.githubusercontent.com/1047502/29801775-6e249ff0-8c3f-11e7-888b-2c4d5177a7d7.png)

After

![screen shot 2017-08-28 at 9 26 40 pm](https://user-images.githubusercontent.com/1047502/29801781-7270c4a8-8c3f-11e7-8b9b-59b2649646f2.png)
Closes https://github.com/facebook/react-native/pull/15685

Differential Revision: D5729420

Pulled By: hramos

fbshipit-source-id: 4866b0b24473ae35e9ebae09f2cee13a49d7717e

2017-08-30 17:16:17 -07:00

android/app

Update OSS Fresco dependency

2017-07-12 07:54:09 -07:00

Alert - allow for hiding alert title on iOS

2017-08-30 17:16:17 -07:00

RNTester

Fix Travis CI runs

2017-06-02 09:03:18 -07:00

RNTester-tvOS

Re-license and rename UIExplorer integration test app as RNTester

2017-05-08 11:31:19 -07:00

RNTester.xcodeproj

Merge fishhook.xcodeproj in RCTWebSocket

2017-08-09 07:48:09 -07:00

RNTesterIntegrationTests

Wait for bridge to disappear when running tests

2017-08-09 09:50:44 -07:00

RNTesterLegacy.xcodeproj

Merge fishhook.xcodeproj in RCTWebSocket

2017-08-09 07:48:09 -07:00

RNTesterUnitTests

RCTShadowView have got rootView property

2017-08-24 00:05:48 -07:00

.eslintrc

Disallow trailing commas in react-native-github

2017-08-17 16:20:04 -07:00

README.md

Move packager launcher scripts outside of packager/

2017-05-23 16:17:09 -07:00

README.md

RNTester

The RNTester showcases React Native views and modules.

Running this app

Before running the app, make sure you ran:

git clone https://github.com/facebook/react-native.git
cd react-native
npm install

Running on iOS

Mac OS and Xcode are required.

Open RNTester/RNTester.xcodeproj in Xcode
Hit the Run button

See Running on device if you want to use a physical device.

Running on Android

You'll need to have all the prerequisites (SDK, NDK) for Building React Native installed.

Start an Android emulator (Genymotion is recommended).

cd react-native
./gradlew :RNTester:android:app:installDebug
./scripts/packager.sh

Note: Building for the first time can take a while.

Open the RNTester app in your emulator.

See Running on Device in case you want to use a physical device.

Running with Buck

Follow the same setup as running with gradle.

Install Buck from here.

Run the following commands from the react-native folder:

./gradlew :ReactAndroid:packageReactNdkLibsForBuck
buck fetch rntester
buck install -r rntester
./scripts/packager.sh

Note: The native libs are still built using gradle. Full build with buck is coming soon(tm).

Built from source

Building the app on both iOS and Android means building the React Native framework from source. This way you're running the latest native and JS code the way you see it in your clone of the github repo.

This is different from apps created using react-native init which have a dependency on a specific version of React Native JS and native code, declared in a package.json file (and build.gradle for Android apps).