status-im
/
react-native
mirror of https://github.com/status-im/react-native.git
2
0
Fork 0
Code Issues Projects Releases Wiki Activity
react-native/Libraries
History
dmueller39 0aea74ebea Fixed incorrect rows reported in onChangeVisibleRows 
Summary:
There is a bug in onChangeVisibleRows when the renderSeparator is not null. The _updateVisibleRows function does not account for the presence of separator frames in the  _childFrames array.

When renderSeparator is not null, increment the totalIndex an additional
time for each row that isn't the last in its section, or the last in the entire
list.

This continues a slightly brittle precedent of having a set of parallel conditions in render and _updateVisibleRows. (i.e. renderSectionHeader is used in both functions, in render as a condition to create a sectionHeader, and in _updateVisibleRows as a condition to increment the totalIndex.

Before change:
![yeeqnmvmif](https://cloud.githubusercontent.com/assets/9422359/14515342/38543952-01c7-11e6-984c-7c1a3fc3d820.gif)

After change:
![gzbrljclzm](https://cloud.githubusercontent.com/assets/9422359/14515340/3296e294-01c7-11e6-8ae9-1ad313600956.gif)

Built using https://gist.github.com/dmueller39/f95028f6fe8bd251944bb604e51f18b2
Closes https://github.com/facebook/react-native/pull/6965

Differential Revision: D3328001

Pulled By: vjeux

fbshipit-source-id: 977e54382ee07be7a432a54febafcae6acaae905
 		2016-05-20 08:13:23 -07:00
..
ART Check if either array is null before diffing 2016-04-25 13:28:31 -07:00
ActionSheetIOS CHORE - Remove Trailing Spaces 2016-04-06 09:21:53 -07:00
AdSupport Text highlighting on iOS 2015-07-24 08:41:58 -08:00
Animated Round alpha channel when interpolating colors to the nearest thousandth. 2016-05-17 10:13:29 -07:00
AppRegistry Refactor BugReporing to avoid multiple registers 2016-05-18 14:28:26 -07:00
AppState Remove knowledge of fbjs from the packager 2016-03-02 04:28:38 -08:00
AppStateIOS Updating AppState to support the inactive state. 2016-03-10 08:30:24 -08:00
BatchedBridge Memoize lazy module configs 2016-05-16 03:58:23 -07:00
BugReporting Make BugReporting not pull in native module on require 2016-05-19 12:58:21 -07:00
CameraRoll Callback with image height and width from IOSImagePicker 2016-05-16 11:13:23 -07:00
Components Fix typo in ViewPagerAndroid.android.js 2016-05-13 11:58:23 -07:00
CustomComponents Fixed incorrect rows reported in onChangeVisibleRows 2016-05-20 08:13:23 -07:00
DebugComponentHierarchy Move React Core Integration to a Dependency 2016-04-21 09:28:23 -07:00
Devtools Move React Core Integration to a Dependency 2016-04-21 09:28:23 -07:00
EventEmitter Fixed NativeEventListener deregistration 2016-05-16 04:13:56 -07:00
Experimental Simplify SwipeableRow styling 2016-05-19 21:43:42 -07:00
Fetch Reject promise if network request failed 2016-03-08 16:37:24 -08:00
Geolocation Fix distanceFilter caching for LocationObserver 2016-05-04 10:35:30 -07:00
Image Reload image without dispatch_async if completion handler is already on main thread 2016-05-17 10:43:30 -07:00
Inspector Add "Open file" button to elements inspector 2016-05-17 20:58:25 -07:00
Interaction Fix JSWatchdog reset 2016-05-03 19:20:26 -07:00
JavaScriptAppEngine Fix source map utils 2016-05-14 10:43:30 -07:00
LayoutAnimation Add support for delete animation in LayoutAnimation on iOS 2016-04-25 00:19:25 -07:00
Linking Mention native code in `Linking` docs 2016-04-20 19:23:19 -07:00
LinkingIOS Added explicit init to observer modules 2016-05-04 07:07:24 -07:00
Modal Modal Status Bar Translucent 2016-05-09 07:08:22 -07:00
NavigationExperimental Fork NavigationAnimatedView to NavigationTransitioner 2016-05-18 13:43:31 -07:00
Network Add comments on NetInfo.js 2016-05-14 21:50:24 -07:00
PullToRefresh Adds progressViewOffset to RefreshControl 2016-05-09 01:51:22 -07:00
PushNotificationIOS Added explicit init to observer modules 2016-05-04 07:07:24 -07:00
QuickPerformanceLogger added QPL for main interactions 2015-09-29 22:25:23 -07:00
RCTTest CHORE - Remove Trailing Spaces 2016-04-06 09:21:53 -07:00
RKBackendNode Move React Core Integration to a Dependency 2016-04-21 09:28:23 -07:00
ReactIOS Fix or suppress errors in react-native 2016-04-21 19:47:24 -07:00
ReactNative Move React Core Integration to a Dependency 2016-04-21 09:28:23 -07:00
Sample Remove knowledge of fbjs from the packager 2016-03-02 04:28:38 -08:00
Settings Remove knowledge of fbjs from the packager 2016-03-02 04:28:38 -08:00
Storage Update AsyncStorage.js 2016-04-10 18:02:20 -07:00
StyleSheet Deprecate transformMatrix and decomposedMatrix 2016-04-29 14:19:25 -07:00
Text iOS: Enable views to be nested within <Text> 2016-05-17 10:43:30 -07:00
Utilities Move infoLog to OSS 2016-05-17 12:43:40 -07:00
Vibration Add support for vibration patterns 2016-03-29 21:45:20 -07:00
WebSocket Updated Websocket to use new event system 2016-05-12 08:30:24 -07:00
react-native Update to React 15.1.0-alpha.1 2016-05-10 15:58:24 -07:00
vendor Fixed NativeEventListener deregistration 2016-05-16 04:13:56 -07:00
Promise.js Remove knowledge of fbjs from the packager 2016-03-02 04:28:38 -08:00
promiseRejectionIsError.js Add possibility to `console.error`/redbox on promise rejections 2016-03-15 05:22:22 -07:00