mirror of
https://github.com/status-im/react-native.git
synced 2025-01-10 01:25:39 +00:00
28c1c88ef7
Summary: - [x] Explain the **motivation** for making this change. - [x] Provide a **test plan** demonstrating that the code is solid. - [x] Match the **code formatting** of the rest of the codebase. - [x] Target the `master` branch, NOT a "stable" branch. There is a problem where setting a bigger fontSize in PickerItem style clips the top and bottom of the text. This solves that problem by computing the row height using the font size. Create a PickerIOS component and set a larger font size (e.g. 50). The row height will grow accordingly. Example with `fontSize=50`: [Screenshot](http://i.imgur.com/YwK5fOc.png) Closes https://github.com/facebook/react-native/pull/13513 Differential Revision: D5692124 Pulled By: shergin fbshipit-source-id: 4629403e37ad68cdbc0b17b48ba924a77e133078
114 lines
2.9 KiB
Objective-C
114 lines
2.9 KiB
Objective-C
/**
|
|
* Copyright (c) 2015-present, Facebook, Inc.
|
|
* All rights reserved.
|
|
*
|
|
* This source code is licensed under the BSD-style license found in the
|
|
* LICENSE file in the root directory of this source tree. An additional grant
|
|
* of patent rights can be found in the PATENTS file in the same directory.
|
|
*/
|
|
|
|
#import "RCTPicker.h"
|
|
|
|
#import "RCTConvert.h"
|
|
#import "RCTUtils.h"
|
|
|
|
@interface RCTPicker() <UIPickerViewDataSource, UIPickerViewDelegate>
|
|
@end
|
|
|
|
@implementation RCTPicker
|
|
|
|
- (instancetype)initWithFrame:(CGRect)frame
|
|
{
|
|
if ((self = [super initWithFrame:frame])) {
|
|
_color = [UIColor blackColor];
|
|
_font = [UIFont systemFontOfSize:21]; // TODO: selected title default should be 23.5
|
|
_selectedIndex = NSNotFound;
|
|
_textAlign = NSTextAlignmentCenter;
|
|
self.delegate = self;
|
|
}
|
|
return self;
|
|
}
|
|
|
|
RCT_NOT_IMPLEMENTED(- (instancetype)initWithCoder:(NSCoder *)aDecoder)
|
|
|
|
- (void)setItems:(NSArray<NSDictionary *> *)items
|
|
{
|
|
_items = [items copy];
|
|
[self setNeedsLayout];
|
|
}
|
|
|
|
- (void)setSelectedIndex:(NSInteger)selectedIndex
|
|
{
|
|
if (_selectedIndex != selectedIndex) {
|
|
BOOL animated = _selectedIndex != NSNotFound; // Don't animate the initial value
|
|
_selectedIndex = selectedIndex;
|
|
dispatch_async(dispatch_get_main_queue(), ^{
|
|
[self selectRow:selectedIndex inComponent:0 animated:animated];
|
|
});
|
|
}
|
|
}
|
|
|
|
#pragma mark - UIPickerViewDataSource protocol
|
|
|
|
- (NSInteger)numberOfComponentsInPickerView:(__unused UIPickerView *)pickerView
|
|
{
|
|
return 1;
|
|
}
|
|
|
|
- (NSInteger)pickerView:(__unused UIPickerView *)pickerView
|
|
numberOfRowsInComponent:(__unused NSInteger)component
|
|
{
|
|
return _items.count;
|
|
}
|
|
|
|
#pragma mark - UIPickerViewDelegate methods
|
|
|
|
- (NSString *)pickerView:(__unused UIPickerView *)pickerView
|
|
titleForRow:(NSInteger)row
|
|
forComponent:(__unused NSInteger)component
|
|
{
|
|
return [RCTConvert NSString:_items[row][@"label"]];
|
|
}
|
|
|
|
- (CGFloat)pickerView:(UIPickerView *)pickerView rowHeightForComponent:(NSInteger)component {
|
|
return _font.pointSize + 19;
|
|
}
|
|
|
|
- (UIView *)pickerView:(UIPickerView *)pickerView
|
|
viewForRow:(NSInteger)row
|
|
forComponent:(NSInteger)component
|
|
reusingView:(UILabel *)label
|
|
{
|
|
if (!label) {
|
|
label = [[UILabel alloc] initWithFrame:(CGRect){
|
|
CGPointZero,
|
|
{
|
|
[pickerView rowSizeForComponent:component].width,
|
|
[pickerView rowSizeForComponent:component].height,
|
|
}
|
|
}];
|
|
}
|
|
|
|
label.font = _font;
|
|
|
|
label.textColor = [RCTConvert UIColor:_items[row][@"textColor"]] ?: _color;
|
|
|
|
label.textAlignment = _textAlign;
|
|
label.text = [self pickerView:pickerView titleForRow:row forComponent:component];
|
|
return label;
|
|
}
|
|
|
|
- (void)pickerView:(__unused UIPickerView *)pickerView
|
|
didSelectRow:(NSInteger)row inComponent:(__unused NSInteger)component
|
|
{
|
|
_selectedIndex = row;
|
|
if (_onChange && _items.count > (NSUInteger)row) {
|
|
_onChange(@{
|
|
@"newIndex": @(row),
|
|
@"newValue": RCTNullIfNil(_items[row][@"value"]),
|
|
});
|
|
}
|
|
}
|
|
|
|
@end
|