react-native/RNTester/RNTesterIntegrationTests/ReferenceImages/RNTester-js-RNTesterApp.ios
Valentin Shergin 8c8944c10f Removing `inherited background color` optimization from RCTText
Summary:
This is a long story. Awhile ago awesome Nick Lockwood (Hey Nick!) introduced a special optimization for ReactNative rendering layer called "inherited background color".
He described this idea in D2811031:
>>>
Blending semitransparent pixels against their background is fairly a fairly expensive operation on mobile GPUs. To reduce blending, React Native has a system called "background color propagation", where the background color of parent views is automatically inherited by child views unless explicitly overridden. This means that translucent pixels can be blended directly against a known background color, avoiding the need to do this dynamically on the GPU.
In practice, this is only useful for views that do their own drawing, which is basically just <Image/> and <Text/> components, and for image components it only really matters when the image has an alpha component.
The automatic background propagation is a bit of a hack, and often does the wrong thing - for example if a view overflows its bounds, or if it overlaps a sibling, the background color will often be incorrect and need to be manually disabled. Because the only place that it provides a significant performance benefit is for text, this diff disables the behavior for everything except <Text/> nodes. It might still be useful for <Image/> nodes too, but looking through the examples in UIExplorer, the number of places where it does the wrong thing for images outnumbers the cases where it provides significant reduction in blending.

However. I think it is time to remove it. Why? There are several reasons:

* It drastically complicates rendering layer. DRASTICALLY. In many many unrelated places (try search for "backgroundColor"!);
* This mechanism is totally non-conceptual to RN and it prevents us to implement some new possible render optimization that we plan to do;
* This adopted only by two components now: Text and ART;
* This is not a significant performance drain anymore; from iOS 6 even UILabel has clear background color by default.
* I doubt that it even works now because `drawRect:` in Text component does not call super method.

So, this diff just turns this feature off for Text. If all performance metrics are neutral, I will delete this mechanism.
Peace.

Reviewed By: sahrens

Differential Revision: D6564199

fbshipit-source-id: 70524fdd955ca32bbf86d2d1ff5e73316b791219
2017-12-15 12:31:58 -08:00
..
testARTExample_1-iOS10@2x.png Removing `inherited background color` optimization from RCTText 2017-12-15 12:31:58 -08:00
testARTExample_1-iOS10_tvOS.png Using `drawViewHierarchyInRect` instead of `renderInContext` for snapshot tests 2017-05-26 15:16:07 -07:00
testARTExample_1-iOS11@2x.png Removing `inherited background color` optimization from RCTText 2017-12-15 12:31:58 -08:00
testARTExample_1@2x.png Removing `inherited background color` optimization from RCTText 2017-12-15 12:31:58 -08:00
testARTExample_1_tvOS.png Using `drawViewHierarchyInRect` instead of `renderInContext` for snapshot tests 2017-05-26 15:16:07 -07:00
testLayoutExample_1-iOS10@2x.png Removing `inherited background color` optimization from RCTText 2017-12-15 12:31:58 -08:00
testLayoutExample_1-iOS10_tvOS.png Using `drawViewHierarchyInRect` instead of `renderInContext` for snapshot tests 2017-05-26 15:16:07 -07:00
testLayoutExample_1-iOS11@2x.png Removing `inherited background color` optimization from RCTText 2017-12-15 12:31:58 -08:00
testLayoutExample_1@2x.png Removing `inherited background color` optimization from RCTText 2017-12-15 12:31:58 -08:00
testLayoutExample_1_tvOS.png Using `drawViewHierarchyInRect` instead of `renderInContext` for snapshot tests 2017-05-26 15:16:07 -07:00
testScrollViewExample_1-iOS10@2x.png Removing `inherited background color` optimization from RCTText 2017-12-15 12:31:58 -08:00
testScrollViewExample_1-iOS10_tvOS.png Revert D5196055: [RN] Intrinsic content size for network image sources of <Image> 2017-10-25 08:20:48 -07:00
testScrollViewExample_1-iOS11@2x.png Removing `inherited background color` optimization from RCTText 2017-12-15 12:31:58 -08:00
testScrollViewExample_1@2x.png Removing `inherited background color` optimization from RCTText 2017-12-15 12:31:58 -08:00
testScrollViewExample_1_tvOS.png Revert D5196055: [RN] Intrinsic content size for network image sources of <Image> 2017-10-25 08:20:48 -07:00
testSliderExample_1-iOS10@2x.png Removing `inherited background color` optimization from RCTText 2017-12-15 12:31:58 -08:00
testSliderExample_1-iOS11@2x.png Removing `inherited background color` optimization from RCTText 2017-12-15 12:31:58 -08:00
testSliderExample_1@2x.png Removing `inherited background color` optimization from RCTText 2017-12-15 12:31:58 -08:00
testSwitchExample_1-iOS10@2x.png Removing `inherited background color` optimization from RCTText 2017-12-15 12:31:58 -08:00
testSwitchExample_1-iOS11@2x.png Removing `inherited background color` optimization from RCTText 2017-12-15 12:31:58 -08:00
testSwitchExample_1@2x.png Removing `inherited background color` optimization from RCTText 2017-12-15 12:31:58 -08:00
testTabBarExample_1-iOS10@2x.png Removing `inherited background color` optimization from RCTText 2017-12-15 12:31:58 -08:00
testTabBarExample_1-iOS10_tvOS.png Using `drawViewHierarchyInRect` instead of `renderInContext` for snapshot tests 2017-05-26 15:16:07 -07:00
testTabBarExample_1-iOS11@2x.png Removing `inherited background color` optimization from RCTText 2017-12-15 12:31:58 -08:00
testTabBarExample_1@2x.png Removing `inherited background color` optimization from RCTText 2017-12-15 12:31:58 -08:00
testTabBarExample_1_tvOS.png Using `drawViewHierarchyInRect` instead of `renderInContext` for snapshot tests 2017-05-26 15:16:07 -07:00
testTextExample_1-iOS10@2x.png Removing `inherited background color` optimization from RCTText 2017-12-15 12:31:58 -08:00
testTextExample_1-iOS10_tvOS.png Using `drawViewHierarchyInRect` instead of `renderInContext` for snapshot tests 2017-05-26 15:16:07 -07:00
testTextExample_1-iOS11@2x.png Removing `inherited background color` optimization from RCTText 2017-12-15 12:31:58 -08:00
testTextExample_1@2x.png Removing `inherited background color` optimization from RCTText 2017-12-15 12:31:58 -08:00
testTextExample_1_tvOS.png Using `drawViewHierarchyInRect` instead of `renderInContext` for snapshot tests 2017-05-26 15:16:07 -07:00
testViewExample_1-iOS10@2x.png Removing `inherited background color` optimization from RCTText 2017-12-15 12:31:58 -08:00
testViewExample_1-iOS10_tvOS.png Using `drawViewHierarchyInRect` instead of `renderInContext` for snapshot tests 2017-05-26 15:16:07 -07:00
testViewExample_1-iOS11@2x.png Removing `inherited background color` optimization from RCTText 2017-12-15 12:31:58 -08:00
testViewExample_1@2x.png Removing `inherited background color` optimization from RCTText 2017-12-15 12:31:58 -08:00
testViewExample_1_tvOS.png Using `drawViewHierarchyInRect` instead of `renderInContext` for snapshot tests 2017-05-26 15:16:07 -07:00