react-native/local-cli
Eric Rozell ec884890b1 Fixing bugs in link and unlink
Summary:
Android uses the name of the package, not the config, for the `isInstalled` check. Sending both parameters to `isInstalled` so we have a consistent API.

<!--
Thank you for sending the PR! We appreciate you spending the time to work on these changes.

Help us understand your motivation by explaining why you decided to make this change.

You can learn more about contributing to React Native here: http://facebook.github.io/react-native/docs/contributing.html

Happy contributing!

-->

A bug was uncovered in the react-native link command where Android would not unlink because the wrong parameters were being sent to `isInstalled`.

Successfully linked and unlinked `react-native-fs` on Windows and Mac. Jest tests pass.

<!--
Help reviewers and the release process by writing your own release notes

**INTERNAL and MINOR tagged notes will not be included in the next version's final release notes.**

  CATEGORY
[----------]        TYPE
[ CLI      ]   [-------------]      LOCATION
[ DOCS     ]   [ BREAKING    ]   [-------------]
[ GENERAL  ]   [ BUGFIX      ]   [-{Component}-]
[ INTERNAL ]   [ ENHANCEMENT ]   [ {File}      ]
[ IOS      ]   [ FEATURE     ]   [ {Directory} ]   |-----------|
[ ANDROID  ]   [ MINOR       ]   [ {Framework} ] - | {Message} |
[----------]   [-------------]   [-------------]   |-----------|

[CATEGORY] [TYPE] [LOCATION] - MESSAGE

 EXAMPLES:

 [IOS] [BREAKING] [FlatList] - Change a thing that breaks other things
 [ANDROID] [BUGFIX] [TextInput] - Did a thing to TextInput
 [CLI] [FEATURE] [local-cli/info/info.js] - CLI easier to do things with
 [DOCS] [BUGFIX] [GettingStarted.md] - Accidentally a thing/word
 [GENERAL] [ENHANCEMENT] [Yoga] - Added new yoga thing/position
 [INTERNAL] [FEATURE] [./scripts] - Added thing to script that nobody will see
-->

[CLI][BUGFIX][local-cli/link/link.js] - Fix issue with `isInstalled` check for Android
[CLI][BUGFIX][local-cli/link/unlink.js] - Fix issue with `isInstalled` check for Android
[CLI][BUGFIX][local-cli/link/ios/common/unregisterNativeModule.js] - Fix references to unregister implementations.
Closes https://github.com/facebook/react-native/pull/18207

Differential Revision: D7180885

Pulled By: hramos

fbshipit-source-id: 5f479cd9d7b1ebd8626b461e9dc1f22988e2c61f
2018-03-07 09:10:23 -08:00
..
__mocks__ Update license headers for MIT license 2018-02-16 18:31:53 -08:00
__tests__ @allow-large-files Upgrade xplat/js to Flow v0.66 2018-02-16 20:24:57 -08:00
bundle Allow passing custom configs through the CLI ("js1 run") 2018-02-26 03:48:43 -08:00
core Update license headers for MIT license 2018-02-16 18:31:53 -08:00
dependencies Remove optional parameter from server and enforce empty list everywhere 2018-03-01 05:33:05 -08:00
eject Update license headers for MIT license 2018-02-16 18:31:53 -08:00
generator Update license headers for MIT license 2018-02-16 18:31:53 -08:00
info Update license headers for MIT license 2018-02-16 18:31:53 -08:00
init Update license headers for MIT license 2018-02-16 18:31:53 -08:00
install Update license headers for MIT license 2018-02-16 18:31:53 -08:00
library Use sync fs.mkdir 2018-02-25 21:49:28 -08:00
link Fixing bugs in link and unlink 2018-03-07 09:10:23 -08:00
logAndroid Update license headers for MIT license 2018-02-16 18:31:53 -08:00
logIOS Update license headers for MIT license 2018-02-16 18:31:53 -08:00
runAndroid Update license headers for MIT license 2018-02-16 18:31:53 -08:00
runIOS Xcode 9 supports running multiple simulators 2018-02-27 14:11:00 -08:00
server Make the chrome debugger handle dynamic delta ids 2018-03-02 02:55:20 -08:00
templates @allow-large-files Upgrade xplat/js to Flow v0.66 2018-02-16 20:24:57 -08:00
upgrade Update license headers for MIT license 2018-02-16 18:31:53 -08:00
util Fix #17610, Add fixtures to metro blacklist 2018-02-16 20:48:15 -08:00
.npmignore npmignore: ignore tests and fixtures 2018-02-27 08:42:14 -08:00
cli.js Update license headers for MIT license 2018-02-16 18:31:53 -08:00
cliEntry.js Update license headers for MIT license 2018-02-16 18:31:53 -08:00
commands.js Update license headers for MIT license 2018-02-16 18:31:53 -08:00
setup_env.bat Update license headers for MIT license 2018-02-16 18:31:53 -08:00
setup_env.sh Update license headers for MIT license 2018-02-16 18:31:53 -08:00
wrong-react-native.js Update license headers for MIT license 2018-02-16 18:31:53 -08:00