react-native/local-cli/util/PackageManager.js
Adam Perry 403f356082 Stop yarn error message appearing for Windows users of local-cli
Summary:
On windows, recent versions of local-cli will display a yarn error to stderr when starting the packager (see https://github.com/expo/xde/issues/91, https://github.com/react-community/create-react-native-app/issues/101, https://github.com/react-community/create-react-native-app/issues/113#issuecomment-289185491 for examples of users hitting this in the wild), even though no package management action is being taken.

From what I can tell this is what happens:

* [`local-cli/util/yarn.js` does not ignore stderr on Windows](6fa87134fc/local-cli/util/yarn.js (L25))
* [`local-cli/util/PackageManager.js` calls the above function when it's require'd](6fa87134fc/local-cli/util/PackageManager.js (L20))

For Windows users who don't have yarn installed, this means that the 'yarn is not recognized as an internal or external command..." error displays wh
Closes https://github.com/facebook/react-native/pull/13355

Differential Revision: D4848084

Pulled By: hramos

fbshipit-source-id: f32176354e0bd7ff6d7009ea30dca64ff23ae3d5
2017-04-07 11:17:00 -07:00

75 lines
1.8 KiB
JavaScript

/**
* Copyright (c) 2015-present, Facebook, Inc.
* All rights reserved.
*
* This source code is licensed under the BSD-style license found in the
* LICENSE file in the root directory of this source tree. An additional grant
* of patent rights can be found in the PATENTS file in the same directory.
*/
'use strict';
const spawnSync = require('child_process').spawnSync;
const yarn = require('../util/yarn');
const spawnOpts = {
stdio: 'inherit',
stdin: 'inherit',
};
/**
* Execute npm or yarn command
*
* @param {String} yarnCommand Yarn command to be executed eg. yarn add package
* @param {String} npmCommand Npm command to be executed eg. npm install package
* @return {object} spawnSync's result object
*/
function callYarnOrNpm(yarnCommand, npmCommand) {
let command;
const projectDir = process.cwd();
const isYarnAvailable =
yarn.getYarnVersionIfAvailable() &&
yarn.isGlobalCliUsingYarn(projectDir);
if (isYarnAvailable) {
command = yarnCommand;
} else {
command = npmCommand;
}
const args = command.split(' ');
const cmd = args.shift();
const res = spawnSync(cmd, args, spawnOpts);
return res;
}
/**
* Install package into project using npm or yarn if available
* @param {[type]} packageName Package to be installed
* @return {[type]} spawnSync's result object
*/
function add(packageName) {
return callYarnOrNpm(
`yarn add ${packageName}`,
`npm install ${packageName} --save`
);
}
/**
* Uninstall package from project using npm or yarn if available
* @param {[type]} packageName Package to be uninstalled
* @return {Object} spawnSync's result object
*/
function remove(packageName) {
return callYarnOrNpm(
`yarn remove ${packageName}`,
`npm uninstall --save ${packageName}`
);
}
module.exports = {
add: add,
remove: remove,
};