status-im
/
react-native
mirror of https://github.com/status-im/react-native.git
2
0
Fork 0
Code Issues Projects Releases Wiki Activity
react-native/Libraries/Components
History
Simon Dohmen d73446c549 Fixed position of ripple-effect 
Summary:
I recognised that the ripple effect was always located at the bottom of my buttons. So i started to search for other ppl having the same problem. I also found this bug on the f8 app.

The gifs show the behaviour before and after my changes:

[The ripple effect is always on the bottom of the element, because pageY is used instead of the relative pos]
![before](https://cloud.githubusercontent.com/assets/956410/16042805/df49d97e-323c-11e6-8ce2-b0658ec85b27.gif)

![after](https://cloud.githubusercontent.com/assets/956410/16042804/df483a60-323c-11e6-862f-e8c97b835339.gif)

Before, the absolute position of the touch was used to update the position during movement but it should be the relative position. Just some small calculation changes were needed to achieve the correct behaviour :)
Closes https://github.com/facebook/react-native/pull/8111

Differential Revision: D3539652

fbshipit-source-id: dd8c8f3c7402d0d435f1c2ca67c1a59b474efda3
 		2016-07-08 19:33:20 -07:00
..
ActivityIndicator Remove `node_modules/react` from the list of discoverable haste modules 2016-07-05 06:44:33 -07:00
Clipboard Annotate Clipboard module 2016-02-15 10:05:34 -08:00
DatePicker Remove `node_modules/react` from the list of discoverable haste modules 2016-07-05 06:44:33 -07:00
DatePickerAndroid Remove knowledge of fbjs from the packager 2016-03-02 04:28:38 -08:00
DrawerAndroid Remove `node_modules/react` from the list of discoverable haste modules 2016-07-05 06:44:33 -07:00
Intent Remove knowledge of fbjs from the packager 2016-03-02 04:28:38 -08:00
Keyboard Remove `node_modules/react` from the list of discoverable haste modules 2016-07-05 06:44:33 -07:00
MapView Remove `node_modules/react` from the list of discoverable haste modules 2016-07-05 06:44:33 -07:00
Navigation Remove `node_modules/react` from the list of discoverable haste modules 2016-07-05 06:44:33 -07:00
Picker Remove `node_modules/react` from the list of discoverable haste modules 2016-07-05 06:44:33 -07:00
ProgressBarAndroid Remove `node_modules/react` from the list of discoverable haste modules 2016-07-05 06:44:33 -07:00
ProgressViewIOS Remove `node_modules/react` from the list of discoverable haste modules 2016-07-05 06:44:33 -07:00
RefreshControl Remove `node_modules/react` from the list of discoverable haste modules 2016-07-05 06:44:33 -07:00
ScrollView Remove `node_modules/react` from the list of discoverable haste modules 2016-07-05 06:44:33 -07:00
SegmentedControlIOS Remove `node_modules/react` from the list of discoverable haste modules 2016-07-05 06:44:33 -07:00
Slider Remove `node_modules/react` from the list of discoverable haste modules 2016-07-05 06:44:33 -07:00
SliderIOS Remove `node_modules/react` from the list of discoverable haste modules 2016-07-05 06:44:33 -07:00
StatusBar Improve autogen for reference docs including jsdoc support 2016-06-21 14:28:43 -07:00
Switch Remove `node_modules/react` from the list of discoverable haste modules 2016-07-05 06:44:33 -07:00
SwitchAndroid Remove `node_modules/react` from the list of discoverable haste modules 2016-07-05 06:44:33 -07:00
SwitchIOS Remove `node_modules/react` from the list of discoverable haste modules 2016-07-05 06:44:33 -07:00
TabBarIOS TabBarIOS itemPositioning - Fixes #4136 2016-05-20 17:28:50 -07:00
TextInput Implement TextInput onContentSizeChange 2016-07-07 09:00:01 -07:00
TimePickerAndroid Fixed typo in docs 2016-04-06 08:55:20 -07:00
ToastAndroid Remove knowledge of fbjs from the packager 2016-03-02 04:28:38 -08:00
ToolbarAndroid Remove `node_modules/react` from the list of discoverable haste modules 2016-07-05 06:44:33 -07:00
Touchable Fixed position of ripple-effect 2016-07-08 19:33:20 -07:00
UnimplementedViews Quick fix to require cycle in UnimplementedView 2015-11-23 14:14:32 -08:00
View Remove `node_modules/react` from the list of discoverable haste modules 2016-07-05 06:44:33 -07:00
ViewPager Remove `node_modules/react` from the list of discoverable haste modules 2016-07-05 06:44:33 -07:00
WebView Remove `node_modules/react` from the list of discoverable haste modules 2016-07-05 06:44:33 -07:00
LazyRenderer.js Decrease TTRR (time to relay request) by lazy rendering fake group header 2016-04-17 15:04:19 -07:00
ScrollResponder.js Remove `node_modules/react` from the list of discoverable haste modules 2016-07-05 06:44:33 -07:00
StaticContainer.js Remove `node_modules/react` from the list of discoverable haste modules 2016-07-05 06:44:33 -07:00
StaticRenderer.js explicit type args in react-native-github 2016-05-24 18:28:26 -07:00
Subscribable.js [ReactNative] clean lint for Libraries/Components 2015-05-18 15:54:07 -08:00