react-native/React
Monte Thakkar 7fbccdea22 Updated RedBox screen (#22242)
Summary:
[Re: RedBox screen is a bit scary - Discussions and Proposals](https://github.com/react-native-community/discussions-and-proposals/issues/42)

Per hramos:
> The RedScreen was inspired by Ruby on Rails's error screen

> I do see the RedBox screen could be made less jarring while still successfully displaying all the information we need.

Hence jamonholmgren came up with the idea that only the header & footer of the RedBox screen could be red. This makes the content a bit more readable as well as makes the screen a little less intimidating.

Also frantic made the suggestion that since the bottom buttons are not as important, they don't need to stand out. Hence only the header of the RedBox screen which displays the error is made red.

Screenshots:
----------

<div style="flex-direction: row">
<img width="325" alt="orginal" src="https://user-images.githubusercontent.com/7840686/48322916-b4958b80-e5de-11e8-9276-33378d1b41c5.png">
<img width="320" alt="redbox_v2_ios" src="https://user-images.githubusercontent.com/7840686/48665300-cce32b80-ea60-11e8-8e8f-88f74bad30ca.png">

</div>

<div style="flex-direction: row">
<img width="300" alt="original_android" src="https://user-images.githubusercontent.com/7840686/48322958-d5f67780-e5de-11e8-891c-1b20bd00e67b.png">
<img width="300" alt="redbox_v2_android" src="https://user-images.githubusercontent.com/7840686/48665312-f13f0800-ea60-11e8-9fb6-47e03c809789.png">

</div>
Pull Request resolved: https://github.com/facebook/react-native/pull/22242

Reviewed By: hramos

Differential Revision: D13564287

Pulled By: cpojer

fbshipit-source-id: fcb6ba5e20d863f4b957d20f3787f5b7a365bfdb
2019-01-15 06:29:49 -08:00
..
Base iOS: Clear `Linking.getInitialURL` during bridge reload (#22659) 2019-01-15 02:10:08 -08:00
CxxBridge iOS: guard against bad RCTModuleData instance 2018-12-26 11:11:12 -08:00
CxxModule iOS changes to switch to JSI 2018-10-18 01:06:24 -07:00
CxxUtils Update copyright headers to yearless format 2018-09-11 15:33:07 -07:00
DevSupport RN: Missing Copyright Headers 2018-10-31 01:37:26 -07:00
Fabric tighter ContextContainer semantics 2018-12-21 18:00:36 -08:00
Inspector RN: Missing Copyright Headers 2018-10-31 01:37:26 -07:00
Modules Updated RedBox screen (#22242) 2019-01-15 06:29:49 -08:00
Profiler Update copyright headers to yearless format 2018-09-11 15:33:07 -07:00
React.xcodeproj Switch storage in `YGStyle` to `CompactValue` 2018-12-18 08:15:09 -08:00
UIUtils Update copyright headers to yearless format 2018-09-11 15:33:07 -07:00
Views Unify native props 2019-01-07 15:39:21 -08:00
.clang-format Defining explicit clang-format for Objective-C part of React Native 2018-11-15 20:28:14 -08:00
third-party.xcconfig Upgrade folly to v2018.10.22.00 for iOS (#21976) 2018-10-29 12:13:11 -07:00