status-im
/
react-native
mirror of https://github.com/status-im/react-native.git
2
0
Fork 0
Code Issues Projects Releases Wiki Activity
react-native/local-cli
History
Steve Kellock f49093f397 Fixes launching Visual Studio Code due to args being a nested array. 
Summary:
**Motivation**

Visual Studio Code appears to have been accidentally borked in RN 38 & 39.

[Here you see](a643784144 (diff-9ad1aafc931637a94d74b60c06b46871R153)) args become an array to support the new `shell-quote` support.

Problem is, `getArgumentsForLineNumber` also returns an array.

[And because we](a643784144 (diff-9ad1aafc931637a94d74b60c06b46871R161)) `push` instead of `concat`, we get hawt array-on-array action.

Surprisingly Atom works.  But Code doesn't like this at all.

**Test plan (required)**

On RN 0.38 and 0.39, what's happening when I click on the simulator stack frame, Code opens with the array as a string...

![image](https://cloud.githubusercontent.com/assets/68273/20971724/83a3d7c4-bc60-11e6-8170-a1c2a4adee60.png)

I've tested Vim, Code and Atom (all on 10.11.6) as well as all combinations of `REACT_EDITOR` both set
Closes https://github.com/facebook/react-native/pull/11345

Differential Revision: D4339963

Pulled By: lacker

fbshipit-source-id: 030cb9e3d84fd6861f28e3652bebfe2eef28dd62
 		2016-12-16 10:28:35 -08:00
..
__mocks__ Fix lint in local-cli 2016-11-14 11:13:42 -08:00
bundle fbsource 2016-12-13 18:58:34 -08:00
core react-native link (aka rnpm) support for Windows 2016-12-10 16:58:28 -08:00
dependencies BREAKING: expose `getTransformOptions` directly in configuration 2016-11-28 07:28:33 -08:00
generator Fix instructions in 'react-native init' 2016-12-12 09:13:30 -08:00
init CLI: Show npm / yarn output during 'react-native-init' when installing React and Jest 2016-12-06 13:58:31 -08:00
install Further RNPM integration 2016-08-22 08:58:37 -07:00
library Fix lint in local-cli 2016-11-21 10:28:34 -08:00
link react-native link (aka rnpm) support for Windows 2016-12-10 16:58:28 -08:00
logAndroid Use native Promise in local-cli 2016-11-21 10:28:34 -08:00
logIOS Use native Promise in local-cli 2016-11-21 10:28:34 -08:00
runAndroid run-android-on-specific-device 2016-12-15 19:43:32 -08:00
runIOS Make run-ios find if a device is booted better 2016-12-01 09:58:32 -08:00
server Fixes launching Visual Studio Code due to args being a nested array. 2016-12-16 10:28:35 -08:00
templates/HelloWorld BREAKING: Android - ReactNativeHost getUseDeveloperSupport to public #2 2016-12-15 21:13:38 -08:00
upgrade New upgrading process, relying on Git 2016-11-28 08:28:35 -08:00
util Fix a bug in determining if yarn is available 2016-12-05 06:13:33 -08:00
.eslintrc Break out defaults, add flow for Config 2016-10-22 06:13:42 -07:00
cli.js Monkey-patch `fs` with graceful-fs before anything else runs 2016-10-14 11:13:54 -07:00
cliEntry.js Use native Promise in local-cli 2016-11-21 10:28:34 -08:00
commands.js Rewrite 'react-native init' and 'react-native upgrade' without using Yeoman in preparation for templates support 2016-11-18 18:28:51 -08:00
default.config.js Allow custom platforms for the RN Packager on a per-project basis 2016-12-02 09:43:31 -08:00
setup_env.bat Fix comments on .bat file 2015-10-28 21:36:07 -04:00
setup_env.sh Change ulimit to 2048 for non root Mac users 2016-02-06 11:45:37 -08:00
wrong-react-native.js Fix usage of react-native cli inside package.json scripts 2016-04-26 15:42:35 -07:00