mirror of
https://github.com/status-im/react-native.git
synced 2025-01-10 09:35:48 +00:00
1e52ef23e7
Summary: Hi, While implementing my own `RCTURLRequestHandler` I came across retain cycles in `RCTNetworkTask` when used with `RCTFileRequestHandler` and `RCTDataRequestHandler`. The `NSBlockOperation` used in `RCTFileRequestHandler` and `RCTDataRequestHandler` could never be dealloc'ed because of a retain cycle. And then the second issue was that those blocks were also strongly capturing the passed delegate which in this case is the `RCTNetworkTask` itself and then since the task was storing the block as a `requestToken`, the task could never be dealloc'ed as well. Here are my proposed fixes. Let me know what you think. Closes https://github.com/facebook/react-native/pull/3884 Reviewed By: svcscm Differential Revision: D2615353 Pulled By: nicklockwood fb-gh-sync-id: a73cbecffbebea75aaeb23d39f04a0d87602926f
93 lines
2.7 KiB
Objective-C
93 lines
2.7 KiB
Objective-C
/**
|
|
* Copyright (c) 2015-present, Facebook, Inc.
|
|
* All rights reserved.
|
|
*
|
|
* This source code is licensed under the BSD-style license found in the
|
|
* LICENSE file in the root directory of this source tree. An additional grant
|
|
* of patent rights can be found in the PATENTS file in the same directory.
|
|
*/
|
|
|
|
#import "RCTFileRequestHandler.h"
|
|
|
|
#import <MobileCoreServices/MobileCoreServices.h>
|
|
|
|
#import "RCTUtils.h"
|
|
|
|
@implementation RCTFileRequestHandler
|
|
{
|
|
NSOperationQueue *_fileQueue;
|
|
}
|
|
|
|
RCT_EXPORT_MODULE()
|
|
|
|
- (void)invalidate
|
|
{
|
|
[_fileQueue cancelAllOperations];
|
|
_fileQueue = nil;
|
|
}
|
|
|
|
- (BOOL)canHandleRequest:(NSURLRequest *)request
|
|
{
|
|
return
|
|
[request.URL.scheme caseInsensitiveCompare:@"file"] == NSOrderedSame
|
|
&& !RCTIsXCAssetURL(request.URL);
|
|
}
|
|
|
|
- (NSOperation *)sendRequest:(NSURLRequest *)request
|
|
withDelegate:(id<RCTURLRequestDelegate>)delegate
|
|
{
|
|
// Lazy setup
|
|
if (!_fileQueue) {
|
|
_fileQueue = [NSOperationQueue new];
|
|
_fileQueue.maxConcurrentOperationCount = 4;
|
|
}
|
|
|
|
__weak __block NSBlockOperation *weakOp;
|
|
__block NSBlockOperation *op = [NSBlockOperation blockOperationWithBlock:^{
|
|
|
|
// Get content length
|
|
NSError *error = nil;
|
|
NSFileManager *fileManager = [NSFileManager new];
|
|
NSDictionary *fileAttributes = [fileManager attributesOfItemAtPath:request.URL.path error:&error];
|
|
if (error) {
|
|
[delegate URLRequest:weakOp didCompleteWithError:error];
|
|
return;
|
|
}
|
|
|
|
// Get mime type
|
|
NSString *fileExtension = [request.URL pathExtension];
|
|
NSString *UTI = (__bridge_transfer NSString *)UTTypeCreatePreferredIdentifierForTag(
|
|
kUTTagClassFilenameExtension, (__bridge CFStringRef)fileExtension, NULL);
|
|
NSString *contentType = (__bridge_transfer NSString *)UTTypeCopyPreferredTagWithClass(
|
|
(__bridge CFStringRef)UTI, kUTTagClassMIMEType);
|
|
|
|
// Send response
|
|
NSURLResponse *response = [[NSURLResponse alloc] initWithURL:request.URL
|
|
MIMEType:contentType
|
|
expectedContentLength:[fileAttributes[NSFileSize] ?: @-1 integerValue]
|
|
textEncodingName:nil];
|
|
|
|
[delegate URLRequest:weakOp didReceiveResponse:response];
|
|
|
|
// Load data
|
|
NSData *data = [NSData dataWithContentsOfURL:request.URL
|
|
options:NSDataReadingMappedIfSafe
|
|
error:&error];
|
|
if (data) {
|
|
[delegate URLRequest:weakOp didReceiveData:data];
|
|
}
|
|
[delegate URLRequest:weakOp didCompleteWithError:error];
|
|
}];
|
|
|
|
weakOp = op;
|
|
[_fileQueue addOperation:op];
|
|
return op;
|
|
}
|
|
|
|
- (void)cancelRequest:(NSOperation *)op
|
|
{
|
|
[op cancel];
|
|
}
|
|
|
|
@end
|