status-im
/
react-native
mirror of https://github.com/status-im/react-native.git
2
0
Fork 0
Code Issues Projects Releases Wiki Activity
react-native/Libraries/Image
History
Toby Cox 1a62b66c51 FIX #9751 - Cancelling offscreen image loads causing crashes 
Summary:
This fixes https://github.com/facebook/react-native/issues/9751

We were seeing the same issues as the original reporter.

I'm not an expert on this code, so apologies if it's naive, but we haven't seen the crash since making this change.

From my understanding of it, it seems like the `cancelLoad` block was being released before the block returned by `_loadImageOrDataWithURLRequest:` was called.
This PR checks the `cancelled` flag before calling `cancelLoad()`.
Closes https://github.com/facebook/react-native/pull/10016

Differential Revision: D3902723

Pulled By: javache

fbshipit-source-id: 75cd115e28694105c6fc29469986998ca0d4cd09
 		2016-09-21 14:28:43 -07:00
..
RCTImage.xcodeproj Update React Native minimum OS version to iOS8 2016-09-01 19:43:47 -07:00
__mocks__ Fixed test CRMNowThumbnailCache-test.js 2016-08-03 06:13:29 -07:00
__tests__ Update Jest APIs on fbsource 2016-04-27 19:16:32 -07:00
AssetRegistry.js [ReactNative] Teach flow how to deal with images 2015-08-26 18:26:09 -08:00
AssetSourceResolver.js Fixes OSS build: haste module -> commonJS invariant 2016-03-16 06:57:26 -07:00
GlobalImageStub.js Removed references to isStatic from the codebase 2015-10-13 06:44:30 -07:00
Image.android.js Fix invalid package name and Remove unsupported prop in Image.android.js 2016-09-14 13:43:48 -07:00
Image.ios.js Add partial image loading to RCTImageView 2016-09-21 12:14:09 -07:00
ImageEditor.js Auto-fix lint errors 2016-08-09 06:43:46 -07:00
ImageResizeMode.js Add Image resizeMode repeat on iOS 2016-06-22 04:28:44 -07:00
ImageSource.js Auto-fix lint errors 2016-08-09 06:43:46 -07:00
ImageSourcePropType.js Support bundle argument for image loading 2016-08-31 17:43:49 -07:00
ImageStore.js Open sourced <ImageEditor>, <ImageStore> for Android 2016-01-27 10:50:54 -08:00
ImageStylePropTypes.js Remove `node_modules/react` from the list of discoverable haste modules 2016-07-05 06:44:33 -07:00
RCTGIFImageDecoder.h Added RCTDataRequestHandler 2015-10-19 09:07:06 -07:00
RCTGIFImageDecoder.m Fix GIF Disappear when return from background 2016-06-24 03:28:24 -07:00
RCTImageBlurUtils.h Add blur effect to RCTImageView 2016-03-17 12:25:40 -07:00
RCTImageBlurUtils.m Add blur effect to RCTImageView 2016-03-17 12:25:40 -07:00
RCTImageCache.h Add custom cache setter 2016-08-01 22:13:27 -07:00
RCTImageCache.m Define the Image Cache delegate to be used in the ImageLoader 2016-07-28 08:58:34 -07:00
RCTImageEditingManager.h
…
RCTImageEditingManager.m Automated changes to remove implicit capture of self in blocks: Libraries/FBReactKit/BUCK 2016-07-07 12:44:14 -07:00
RCTImageLoader.h Add partial image loading to RCTImageView 2016-09-21 12:14:09 -07:00
RCTImageLoader.m FIX #9751 - Cancelling offscreen image loads causing crashes 2016-09-21 14:28:43 -07:00
RCTImageStoreManager.h RTCImageStoreManager uses NSData instead of UIImage 2015-11-17 09:55:31 -08:00
RCTImageStoreManager.m Fix misusage of NSUInteger * in RCTImageStoreManager 2016-07-12 13:58:28 -07:00
RCTImageUtils.h Removed placeholder image logic 2016-04-25 03:31:19 -07:00
RCTImageUtils.m Add Image resizeMode center to iOS 2016-07-19 03:43:26 -07:00
RCTImageView.h Rename RCTImageView source to imageSources 2016-08-23 11:28:42 -07:00
RCTImageView.m Add partial image loading to RCTImageView 2016-09-21 12:14:09 -07:00
RCTImageViewManager.h
…
RCTImageViewManager.m Add partial image loading to RCTImageView 2016-09-21 12:14:09 -07:00
RCTLocalAssetImageLoader.h Load local assets synchronously to prevent image flicker 2016-07-21 07:58:51 -07:00
RCTLocalAssetImageLoader.m Add partial image loading to RCTImageView 2016-09-21 12:14:09 -07:00
RCTResizeMode.h Add Image resizeMode center to iOS 2016-07-19 03:43:26 -07:00
RCTResizeMode.m Add Image resizeMode center to iOS 2016-07-19 03:43:26 -07:00
RelativeImageStub.js [ReactNative] Teach flow how to deal with images 2015-08-26 18:26:09 -08:00
resolveAssetSource.js Introduce custom asset resolver to resolveAssetSource(..) 2016-03-15 20:20:27 -07:00