mirror of
https://github.com/status-im/react-native.git
synced 2025-02-22 14:18:23 +00:00
0a20f47021
Summary: @public This diff changes how we store and manage Yoga Config in layoutable shadow nodes. Previously we have `shared_ptr` to single shared yoga config (one to many relationships); now we initiate and store yoga config with yoga node (one to one relationship). Cons: - Less memory efficient. Pros: - Much more flexible model. Configuration can be tweaked on a per-node basis. - More performant. Dealing with `shared_ptr` is expensive because of atomic ref-counter. (This is not really applicable for the previous approach but would be applicable for any alternate approach where we want to have more granular control of the configuration.) Data locality is also great in the new model which should positively impact performance. - Simplicity. Any alternate approach where we manage sets of nodes which share the same configuration is going to be quite complex. Reviewed By: fkgozali Differential Revision: D8475638 fbshipit-source-id: 5d73116718ced8e4b2d31d857bb9aac69eb69f2b
104 lines
2.9 KiB
C++
104 lines
2.9 KiB
C++
/**
|
|
* Copyright (c) 2015-present, Facebook, Inc.
|
|
*
|
|
* This source code is licensed under the MIT license found in the
|
|
* LICENSE file in the root directory of this source tree.
|
|
*/
|
|
|
|
#pragma once
|
|
|
|
#include <memory>
|
|
#include <vector>
|
|
|
|
#include <yoga/YGNode.h>
|
|
|
|
#include <fabric/core/LayoutableShadowNode.h>
|
|
#include <fabric/core/Sealable.h>
|
|
#include <fabric/core/ShadowNode.h>
|
|
#include <fabric/debug/DebugStringConvertible.h>
|
|
#include <fabric/view/YogaStylableProps.h>
|
|
|
|
namespace facebook {
|
|
namespace react {
|
|
|
|
class YogaLayoutableShadowNode;
|
|
|
|
using SharedYogaConfig = std::shared_ptr<YGConfig>;
|
|
|
|
using SharedYogaLayoutableShadowNode = std::shared_ptr<const YogaLayoutableShadowNode>;
|
|
using SharedYogaLayoutableShadowNodeList = std::vector<const SharedYogaLayoutableShadowNode>;
|
|
using SharedYogaLayoutableShadowNodeSharedList = std::shared_ptr<const SharedYogaLayoutableShadowNodeList>;
|
|
|
|
class YogaLayoutableShadowNode:
|
|
public LayoutableShadowNode,
|
|
public virtual DebugStringConvertible,
|
|
public virtual Sealable {
|
|
|
|
public:
|
|
|
|
#pragma mark - Constructors
|
|
|
|
YogaLayoutableShadowNode(
|
|
const SharedYogaStylableProps &props,
|
|
const SharedShadowNodeSharedList &children
|
|
);
|
|
|
|
YogaLayoutableShadowNode(
|
|
const SharedYogaLayoutableShadowNode &shadowNode,
|
|
const SharedYogaStylableProps &props = nullptr,
|
|
const SharedShadowNodeSharedList &children = nullptr
|
|
);
|
|
|
|
#pragma mark - Mutating Methods
|
|
|
|
/*
|
|
* Connects `measureFunc` function of Yoga node with
|
|
* `LayoutableShadowNode::measure()` method.
|
|
*/
|
|
void enableMeasurement();
|
|
|
|
/*
|
|
* Appends `child`'s Yoga node to the own Yoga node.
|
|
* So, it complements `ShadowNode::appendChild(...)` functionality from Yoga
|
|
* perspective.
|
|
*/
|
|
void appendChild(SharedYogaLayoutableShadowNode child);
|
|
|
|
void cleanLayout() override;
|
|
void dirtyLayout() override;
|
|
bool getIsLayoutClean() const override;
|
|
|
|
void setHasNewLayout(bool hasNewLayout) override;
|
|
bool getHasNewLayout() const override;
|
|
|
|
/*
|
|
* Computes layout using Yoga layout engine.
|
|
* See `LayoutableShadowNode` for more details.
|
|
*/
|
|
void layout(LayoutContext layoutContext) override;
|
|
|
|
void layoutChildren(LayoutContext layoutContext) override;
|
|
|
|
protected:
|
|
/*
|
|
* All Yoga functions only accept non-const arguments, so we have to mark
|
|
* Yoga node as `mutable` here to avoid `static_cast`ing the pointer to this
|
|
* all the time.
|
|
*/
|
|
mutable YGNode yogaNode_;
|
|
|
|
/*
|
|
* Yoga config associated (only) with this particular node.
|
|
*/
|
|
YGConfig yogaConfig_;
|
|
|
|
private:
|
|
static void initializeYogaConfig(YGConfig &config);
|
|
static void setYogaNodeChildrenBasedOnShadowNodeChildren(YGNode *yogaNodeRawPtr, const SharedShadowNodeSharedList &children);
|
|
static YGNode *yogaNodeCloneCallbackConnector(YGNode *oldYogaNode, YGNode *parentYogaNode, int childIndex);
|
|
static YGSize yogaNodeMeasureCallbackConnector(YGNode *yogaNode, float width, YGMeasureMode widthMode, float height, YGMeasureMode heightMode);
|
|
};
|
|
|
|
} // namespace react
|
|
} // namespace facebook
|