A framework for building native apps with React. http://facebook.github.io/react-native/
Go to file
Jean Regisser 7f9ec4e4c8 Fixed incorrect style props passed to Android Image when using children
Summary:
Hi there,

Here is a fix for #7538 (and #5085).

I had originally discovered this issue when using `resizeMode` through the style props. Although this might arguably be an incorrect usage (see https://github.com/facebook/react-native/issues/4759#issuecomment-164301166) the same issue would happen with the `tintColor` and `overlayColor` style props.

To  test this, you can render the following:

```jsx
const imageContainerStyle = {width: 100, height: 100, backgroundColor: 'green', marginLeft: 10, marginTop: 10, };
const imageStyle = {flex: 1, width: undefined, height: undefined, resizeMode: 'contain', };

return (
  <View style={styles.container}>
    <View style={imageContainerStyle}>
      <Image style={imageStyle} source={
        {uri:'http://resizing.flixster.com/DeLpPTAwX3O2LszOpeaMHjbzuAw=/53x77/dkpu1ddg7pbsk.cloudfront.net/movie/11/16/47/11164719_ori.jpg'}
      }>
      </Image>
    </View>
    <View style={imageContainerStyle}>
      <Image style={imageStyle} source={
        {
Closes https://github.com/facebook/react-native/pull/8410

Differential Revision: D3488010

Pulled By: andreicoman11

fbshipit-source-id: e9d1283cce8426c8878f9c3c66a43a2141232277
2016-06-27 03:28:31 -07:00
.github move templates to .github folder 2016-06-13 07:43:28 -07:00
Examples Added the ability to set an image title in the NavigatorIOS 2016-06-23 08:28:30 -07:00
IntegrationTests explicit type args in react-native-github 2016-05-24 18:28:26 -07:00
JSCLegacyProfiler Add suport for JSC profiling on iOS 9 2015-11-16 03:38:11 -08:00
Libraries Fixed incorrect style props passed to Android Image when using children 2016-06-27 03:28:31 -07:00
React Provide function that could read app current using language 2016-06-24 19:43:44 -07:00
ReactAndroid Fix check for if we are ready to make js calls 2016-06-24 19:28:34 -07:00
ReactCommon/cxxreact Serialize params when making/queuing native call 2016-06-23 14:58:58 -07:00
Tools/FBPortForwarding Open source FBPortForwarding 2016-03-24 10:51:34 -07:00
babel-preset Fixing Issue #7526 2016-05-26 13:43:29 -07:00
blog Fixed a few language errors in the Introducing Hot Reloading blog post. 2016-05-13 08:58:24 -07:00
bots move templates to .github folder 2016-06-13 07:43:28 -07:00
docs map -> object 2016-06-27 03:13:23 -07:00
flow Deploy v0.23.0 2016-04-14 16:18:41 -07:00
gradle/wrapper Added ability to run Movies app with BUCK 2016-02-25 17:15:58 -08:00
jestSupport Fixed path to regenerator-runtime 2016-05-04 05:19:31 -07:00
keystores Added ability to run Movies app with BUCK 2016-02-25 17:15:58 -08:00
lib Add forwarding modules for modules required by React 2016-05-10 10:31:24 -07:00
local-cli Add missing character into BUCK android template 2016-06-24 17:28:30 -07:00
packager Allow rn-cli.config.js to specify the default transformer 2016-06-22 08:13:26 -07:00
react-native-cli Made react installed via reac-native init strict to unbreak 15.1.0 2016-06-03 03:43:31 -07:00
scripts Improved android e2e tests stability 2016-06-24 16:58:28 -07:00
website Overhaul the Flexbox documentation 2016-06-24 11:58:53 -07:00
.buckconfig Allow building UIExplorer with Buck 2016-04-12 13:05:24 -07:00
.buckjavaargs limiting BUCK's memory for CI 2016-02-01 10:49:33 -08:00
.editorconfig Create .editorconfig 2015-10-09 22:34:00 +01:00
.eslintignore [ReactNative] clean lint in all of Libraries/ 2015-05-19 13:47:04 -08:00
.eslintrc Enable no-duplicate-props lint rule 2016-05-10 05:00:24 -07:00
.flowconfig update flowification of react-native 2016-06-16 15:43:20 -07:00
.gitattributes Added a .gitattributes file, ensuring that Bash script source files (gradlew and 2015-10-13 23:10:39 -04:00
.gitignore Fix tests buck build when running locally 2016-05-16 12:28:40 -07:00
.npmignore Merge rnpm into react-native 2016-05-20 04:58:26 -07:00
.travis.yml Fixed travis stalls by updating to latest node 2016-06-21 10:28:29 -07:00
CONTRIBUTING.md Add note about submitting PRs on master 2016-06-18 02:43:20 -07:00
LICENSE Update license 2015-03-23 10:48:39 -07:00
LICENSE-CustomComponents Add CustomComponents license 2015-03-26 11:03:30 -07:00
LICENSE-docs More licenses 2015-03-24 19:59:10 -07:00
LICENSE-examples More licenses 2015-03-24 19:59:10 -07:00
PATENTS Update Patent Grant 2015-04-10 12:14:22 -07:00
README.md Fix tutorial link in README.md 2016-06-14 06:43:49 -07:00
React.podspec Add C++ and standard v14 settings. 2016-05-27 13:58:31 -07:00
Releases.md Add upcoming releases to the schedule 2016-06-06 04:43:29 -07:00
Windows Fix tutorial link in README.md 2016-06-14 06:43:49 -07:00
breaking-changes.md Update breaking-changes.md 2016-01-16 21:56:57 +00:00
build.gradle Support non-standard path of Android Support Repository 2016-04-21 05:13:34 -07:00
circle.yml Improved android e2e tests stability 2016-06-24 16:58:28 -07:00
cli.js Breaking change: Move `bundle` to `private-cli` 2015-10-13 11:48:30 -07:00
gradlew Upgrade gradle to 2.9 2015-12-14 06:37:34 -08:00
gradlew.bat Release React Native for Android 2015-09-14 18:13:39 +01:00
package.json Update ws dependency 2016-06-22 10:43:24 -07:00
react.gradle Android: allow app/build.gradle to specify how node gets invoked for the packager 2016-06-04 15:58:24 -07:00
runXcodeTests.sh Add suggested ‘view size’ powers to -[RCTShadowView setFrame:] 2016-03-01 10:14:32 -08:00
settings.gradle Delete SampleApp 2015-09-29 09:21:33 -07:00

README.md

React Native Build Status Circle CI npm version

React Native enables you to build world-class application experiences on native platforms using a consistent developer experience based on JavaScript and React. The focus of React Native is on developer efficiency across all the platforms you care about - learn once, write anywhere. Facebook uses React Native in multiple production apps and will continue investing in React Native.

Supported operating systems are >= Android 4.1 (API 16) and >= iOS 7.0.

Introduction

See the official React Native website for an introduction to React Native.

Getting Started

Getting Help

Please use these community resources for getting help. We use the GitHub issues for tracking bugs and feature requests and have limited bandwidth to address them.

Documentation

The websites documentation is divided into multiple sections.

Another great way to learn more about the components and APIs included with React Native is to read their source. Look under the Libraries directory for components like ScrollView and Navigator, for example. The UIExplorer example is also here to demonstrate some of the ways to use these components. From the source you can get an accurate understanding of each components behavior and API.

The React Native documentation only discusses the components, APIs and topics specific to React Native (React on iOS and Android). For further documentation on the React API that is shared between React Native and React DOM, refer to the React documentation.

Examples

  • git clone https://github.com/facebook/react-native.git
  • cd react-native && npm install

Running the examples on iOS

Now open any example (the .xcodeproj file in each of the Examples subdirectories) and hit Run in Xcode.

Running the examples on Android

Note that you'll need the Android NDK installed, see prerequisites.

./gradlew :Examples:Movies:android:app:installDebug
# Start the packager in a separate shell (make sure you ran npm install):
./packager/packager.sh
# Open the Movies app in your emulator

Extending React Native

  • Looking for a component? JS.coach
  • Fellow developers write and publish React Native modules to npm and open source them on GitHub.
  • Making modules helps grow the React Native ecosystem and community. We recommend writing modules for your use cases and sharing them on npm.
  • Read the guides on Native Modules (iOS, Android) and Native UI Components (iOS, Android) if you are interested in extending native functionality.

Upgrading

React Native is under active development. See the guide on upgrading React Native to keep your project up-to-date.

Opening Issues

If you encounter a bug with React Native we would like to hear about it. Search the existing issues and try to make sure your problem doesnt already exist before opening a new issue. Its helpful if you include the version of React Native and OS youre using. Please include a stack trace and reduced repro case when appropriate, too.

The GitHub issues are intended for bug reports and feature requests. For help and questions with using React Native please make use of the resources listed in the Getting Help section. Product Pains in particular is a good way to signal your interest in a feature or issue. There are limited resources available for handling issues and by keeping the list of open issues lean we can respond in a timely manner.

Contributing

For more information about contributing PRs and issues, see our Contribution Guidelines.

Good First Task is a great starting point for PRs.

We encourage the community to ask and answer questions on Stack Overflow with the react-native tag. It's a great way to help out and be involved!

License

React is BSD licensed. We also provide an additional patent grant.

React documentation is Creative Commons licensed.

Examples provided in this repository and in the documentation are separately licensed, as are some of the custom components.