mirror of https://github.com/status-im/react-native.git synced 2025-01-12 18:44:25 +00:00

History

Adam Comella 7e11bad86f Android: Improve getCurrentPosition API

Summary:
We ran into a couple of problems with the implementation of `getCurrentPosition` on Android:
  - It sometimes returns an inaccurate location
  - It times out when `enableHighAccuracy` is `true` (#7495)

This change improves `getCurrentPosition` for both of the above problems. Instead of calling `requestSingleUpdate` it now calls `requestLocationUpdates` so it can receive multiple locations giving it an opportunity to pick a better one. Unlike `requestSingleUpdate`, this approach doesn't seem to timeout when `enableHighAccuracy` is `true`.

**Test plan (required)**

Verified in a test app that `getCurrentPosition` returns a good location and doesn't timeout when `enableHighAccuracy` is `true`. Also, my team has been using this change in our app in production.

Adam Comella
Microsoft Corp.
Closes https://github.com/facebook/react-native/pull/15094

Differential Revision: D5632100

Pulled By: hramos

fbshipit-source-id: 86e40b01d941a13820cb775bccad7e19dba3d692

2017-08-15 12:03:40 -07:00

libs

Apply auto-formatter for BUCK files in fbandroid.

2017-02-27 14:04:56 -08:00

src

Android: Improve getCurrentPosition API

2017-08-15 12:03:40 -07:00

.npmignore

Don't publish /ReactAndroid/build to npm, update version on master

2015-10-12 11:11:40 -07:00

build.gradle

Update OSS Fresco dependency