mirror of
https://github.com/status-im/react-native.git
synced 2025-01-17 13:01:13 +00:00
80f7891287
Summary:
@public
This is follow up for D8601600 and D8247652 (the last one has detailed explanation of the problem).
From this commit I propose that we have to follow simple rule:
If some prop has a default value which differs from the default value of its type, we have to specify it as {<value>} in .h file and explicitly in .m file, for all other props the default value must not be specified explicitly (in .h files it must be specified as {}).
The reason is that we have to embrase those cases and establish behaviour: if we change the default value in .h file, it always means that we have to change the value in .cpp file too.
Reviewed By: fkgozali
Differential Revision: D8601776
fbshipit-source-id: 3379aace4e2d72febb2b942a3da1cb24decf54be
72 lines
1.6 KiB
C++
72 lines
1.6 KiB
C++
/**
|
|
* Copyright (c) 2015-present, Facebook, Inc.
|
|
*
|
|
* This source code is licensed under the MIT license found in the
|
|
* LICENSE file in the root directory of this source tree.
|
|
*/
|
|
|
|
#pragma once
|
|
|
|
#include <fabric/core/Props.h>
|
|
#include <fabric/graphics/Geometry.h>
|
|
#include <fabric/graphics/Color.h>
|
|
#include <fabric/view/AccessibilityProps.h>
|
|
#include <fabric/view/primitives.h>
|
|
#include <fabric/view/YogaStylableProps.h>
|
|
|
|
namespace facebook {
|
|
namespace react {
|
|
|
|
class ViewProps;
|
|
|
|
using SharedViewProps = std::shared_ptr<const ViewProps>;
|
|
|
|
class ViewProps:
|
|
public Props,
|
|
public YogaStylableProps,
|
|
public AccessibilityProps {
|
|
|
|
public:
|
|
|
|
ViewProps() = default;
|
|
ViewProps(const YGStyle &yogaStyle);
|
|
ViewProps(const ViewProps &sourceProps, const RawProps &rawProps);
|
|
|
|
#pragma mark - Props
|
|
|
|
// Color
|
|
const Float opacity {1.0};
|
|
const SharedColor foregroundColor {};
|
|
const SharedColor backgroundColor {};
|
|
|
|
// Borders
|
|
const EdgeInsets borderWidth {};
|
|
const CornerInsets borderRadius {};
|
|
const SharedColor borderColor {};
|
|
const BorderStyle borderStyle {};
|
|
|
|
// Shadow
|
|
const SharedColor shadowColor {};
|
|
const Size shadowOffset {};
|
|
const Float shadowOpacity {};
|
|
const Float shadowRadius {};
|
|
|
|
// Transform
|
|
const Transform transform {};
|
|
const bool backfaceVisibility {};
|
|
const bool shouldRasterize {};
|
|
const int zIndex {};
|
|
|
|
// Events
|
|
const PointerEventsMode pointerEvents {};
|
|
const EdgeInsets hitSlop {};
|
|
const bool onLayout {};
|
|
|
|
#pragma mark - DebugStringConvertible
|
|
|
|
SharedDebugStringConvertibleList getDebugProps() const override;
|
|
};
|
|
|
|
} // namespace react
|
|
} // namespace facebook
|