status-im
/
react-native
mirror of https://github.com/status-im/react-native.git
2
0
Fork 0
Code Issues Projects Releases Wiki Activity
react-native/Libraries/NavigationExperimental
History
ahanriat c658cc545f Fix navigation card stack pan responder 
Summary:
Hi folks !
🔧 Fix the navigation card stack pan responder when the `vertical` direction is enabled.

**Issue:**
When using a `ScrollView` with the `vertical` direction enabled, the pan handler catch the gesture before the `ScrollView`.

I don't know why there was no default value here for `RESPOND_POSITION_MAX_VERTICAL` 5162eb3254
ericvicenti could you tell me what you think about setting a default value for `RESPOND_POSITION_MAX_VERTICAL` ? 😃

Thanks !!

**EDIT June 15, 2016**
I'll update this PR this week end to provide a way to give custom values as there is no magic value for `RESPOND_POSITION_MAX_VERTICAL`

**EDIT June 24, 2016**
I've added a props `gestureResponseDistance` to control both the `RESPOND_POSITION_MAX_VERTICAL` and `RESPOND_POSITION_MAX_HORIZONTAL`
Closes https://github.com/facebook/react-native/pull/8076

Differential Revision: D3605973

Pulled By: ericvicenti

fbshipit-source-id: 158d88cf8ebbab742bf0b38c217ae502e9dd1963
 		2016-07-25 11:58:44 -07:00
..
Reducer Fix NavigationScenesReducer. 2016-06-27 12:13:40 -07:00
__mocks__ Clean up APIs. 2016-03-04 14:57:31 -08:00
__tests__ Add `NavigationStateUtils.back()` and `NavigationStateUtils.forward()`. 2016-06-24 15:28:35 -07:00
NavigationAbstractPanResponder.js Simplify <NavigationCard />. 2016-03-15 15:59:26 -07:00
NavigationExperimental.js Kill NavigationAnimatedView 2016-06-21 15:59:04 -07:00
NavigationPropTypes.js Fix NavigationScenesReducer. 2016-06-27 12:13:40 -07:00
NavigationStateUtils.js Add `NavigationStateUtils.back()` and `NavigationStateUtils.forward()`. 2016-06-24 15:28:35 -07:00
NavigationTransitioner.js Prevent race condition on immediate transition 2016-07-12 13:13:24 -07:00
NavigationTypeDefinition.js Fix navigation card stack pan responder 2016-07-25 11:58:44 -07:00