react-native/React/Views/RCTSlider.m
Brent Vatne 5fb5148e3d [SliderIOS] Apply value after minimum/maximumValue in order to ensure it is properly set
Summary:
`value` is clamped between min/max and so order of prop application matters - `value` always ended up being set first in my tests, and consequently a value outside of the default range 0-1 would not work. So this applies the value when the min/max are set.

[Gist of broken example](https://gist.github.com/brentvatne/fc637b3e21d012966f3a)

![screenshot](http://url.brentvatne.ca/SQPC.png)
^ the second slider here should have it's cursor in the middle

/cc @tadeuzagallo
Closes https://github.com/facebook/react-native/pull/835
Github Author: Brent Vatne <brent.vatne@madriska.com>

Test Plan: Imported from GitHub, without a `Test Plan:` line.
2015-04-21 11:09:10 -08:00

36 lines
717 B
Objective-C

/**
* Copyright (c) 2015-present, Facebook, Inc.
* All rights reserved.
*
* This source code is licensed under the BSD-style license found in the
* LICENSE file in the root directory of this source tree. An additional grant
* of patent rights can be found in the PATENTS file in the same directory.
*/
#import "RCTSlider.h"
@implementation RCTSlider
{
float _unclippedValue;
}
- (void)setValue:(float)value
{
_unclippedValue = value;
super.value = value;
}
- (void)setMinimumValue:(float)minimumValue
{
super.minimumValue = minimumValue;
super.value = _unclippedValue;
}
- (void)setMaximumValue:(float)maximumValue
{
super.maximumValue = maximumValue;
super.value = _unclippedValue;
}
@end