react-native

mirror of https://github.com/status-im/react-native.git synced 2025-02-23 14:48:25 +00:00

History

empyrical 78be6efda9 JSI: Minor tweaks for building on MSVC (#23367 )

Summary:
This pull request makes two minor changes to `jsi.h`:

 * Tweak the `JSI_EXPORT` macro to automatically set itself to an empty value if `_MSC_VER` is defined - like how was done by acoates-ms [here](8beb4bb58a/ReactCommon/cxxreact/JSBigString.h (L15-L21)).
 * Tweak the call to constructor `Pointer(Runtime::PointerValue* ptr)` in the constructor for `PropNameID`. I am not sure why MSVC wasn't working with the original version, but it compiles after I tweak that.

[General] [Fixed] - Tweaked `jsi.h` to build on MSVC
Pull Request resolved: https://github.com/facebook/react-native/pull/23367

Differential Revision: D14032507

Pulled By: cpojer

fbshipit-source-id: 701c13e3509cc244dbe0c15f92067fae4382bee2

2019-02-11 15:42:18 -08:00

better

Fabric: Introducing Better: For faster, clear and ideomatic codebase

2019-02-08 13:57:33 -08:00

config

Reformat xplat build files according to new formatting rules.

2019-01-10 20:00:42 -08:00

cxxreact

JSBigString.h: Remove duplicate include of 'unistd.h' (#23297 )

2019-02-05 12:41:46 -08:00

fabric

Clang-format for all files in Fabric folder